Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for specialized dispatch changes in row hasher #2133

Open
wants to merge 3 commits into
base: branch-24.10
Choose a base branch
from
+7 −2
Open

Fix for specialized dispatch changes in row hasher #2133

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3af009
added support for specializing dispatch for hasher
tgujar Jun 7, 2024
a2be671
Merge branch 'NVIDIA:branch-24.08' into hash-occupancy-jni
tgujar Jul 26, 2024
22b2654
Merge branch 'branch-24.10' into hash-occupancy-jni
tgujar Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/main/cpp/src/murmur_hash.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,15 @@ namespace {
* @tparam hash_function Hash functor to use for hashing elements. Must be SparkMurmurHash3_32.
* @tparam Nullate A cudf::nullate type describing whether to check for nulls.
*/
template <template <typename> class hash_function, typename Nullate>
template <template <typename> class hash_function,
typename Nullate,
template <typename> typename dispatch_conditional_t = cudf::experimental::type_identity_t>
class murmur_device_row_hasher {
friend class cudf::experimental::row::hash::row_hasher; ///< Allow row_hasher to access private
///< members.
template <cudf::type_id T>
using dispatch_conditional =
cudf::experimental::transform_sequence<cudf::id_to_type<T>, dispatch_conditional_t>;

public:
/**
Expand All @@ -80,7 +85,7 @@ class murmur_device_row_hasher {
_seed,
cuda::proclaim_return_type<murmur_hash_value_type>(
[row_index, nulls = this->_check_nulls] __device__(auto hash, auto column) {
return cudf::type_dispatcher(
return cudf::type_dispatcher<dispatch_conditional>(
column.type(), element_hasher_adapter<hash_function>{nulls, hash}, column, row_index);
}));
}
Expand Down