Throughput run uses individual template in full benchmark #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allen Xu <[email protected]>
Signed-off-by: Allen Xu <[email protected]>
|
Do you want to add the sample |
|
No, in that way I'll add another 6 new template files( (cpu/gpu) *(pure parquet/delta/iceberg/) ) but with just like 1 or 2 lines diff for resource limits comparing to the Power template. That's why I mentioned in the README that user can create based on the Power ones. |
mattahrens
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #174
As titled.
This PR adds in a new config for throughput run template file. This template file should have resource limit to allow concurrent streams during throughput test.
To avoid too many template files and also considering the highly overlap content between that and power run template, we don't adds in additional template files. User can copy the one for Power Run directly and add resource limit.