-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit with nonzero if any task failed #166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exit 1 if any task failed CI should use nofailure Signed-off-by: Gary Shen <[email protected]>
Signed-off-by: Gary Shen <[email protected]>
Signed-off-by: Gary Shen <[email protected]>
Add more print Signed-off-by: Gary Shen <[email protected]>
Signed-off-by: Gary Shen <[email protected]>
Check exit_code not zero Signed-off-by: Gary Shen <[email protected]>
gerashegalov
previously approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jlowe
reviewed
Oct 23, 2023
jlowe
reviewed
Oct 23, 2023
Always print out the failure Just exit non-zero code without allow_failure parameter Signed-off-by: Gary Shen <[email protected]>
Signed-off-by: Gary Shen <[email protected]>
jlowe
reviewed
Oct 24, 2023
jlowe
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an arg '--allow_failure'
Save the query reports into an array
Check the query reports after running and exit with non-zero value to represent a failure of the script if no flag '--allow_failure'
Print out the query which status is 'Failed' or 'CompletedWithFailedTask'
Close #147