Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with nonzero if any task failed #166

Merged
merged 8 commits into from
Jan 4, 2024
Merged

Conversation

GaryShen2008
Copy link
Collaborator

@GaryShen2008 GaryShen2008 commented Oct 9, 2023

Add an arg '--allow_failure'
Save the query reports into an array
Check the query reports after running and exit with non-zero value to represent a failure of the script if no flag '--allow_failure'
Print out the query which status is 'Failed' or 'CompletedWithFailedTask'

Close #147

Exit 1 if any task failed
CI should use nofailure

Signed-off-by: Gary Shen <[email protected]>
Signed-off-by: Gary Shen <[email protected]>
Signed-off-by: Gary Shen <[email protected]>
Add more print

Signed-off-by: Gary Shen <[email protected]>
Signed-off-by: Gary Shen <[email protected]>
nds/PysparkBenchReport.py Outdated Show resolved Hide resolved
nds/nds_power.py Outdated Show resolved Hide resolved
Check exit_code not zero

Signed-off-by: Gary Shen <[email protected]>
gerashegalov
gerashegalov previously approved these changes Oct 23, 2023
Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nds/nds_power.py Outdated Show resolved Hide resolved
nds/nds_power.py Outdated Show resolved Hide resolved
Always print out the failure
Just exit non-zero code without allow_failure parameter

Signed-off-by: Gary Shen <[email protected]>
Signed-off-by: Gary Shen <[email protected]>
@GaryShen2008 GaryShen2008 merged commit fbf4e58 into NVIDIA:dev Jan 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] If any query fails in NDS benchmark, then overall job should return as failed
3 participants