Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in mounts cache #737

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elezar
Copy link
Member

@elezar elezar commented Oct 11, 2024

This change switches to using the WithCache decorator for mounts instead of keeping track of a cache locally.

This addresses a race condition when using the mounts structure.

Fixes #731

This change switches to using the WithCache decorator for
mounts instead of keeping track of a cache locally.

This addresses a race condition when using the mounts structure.

Signed-off-by: Evan Lezar <[email protected]>
@elezar elezar requested review from klueska and cdesiniotis October 11, 2024 13:59
@elezar elezar linked an issue Oct 11, 2024 that may be closed by this pull request
@elezar elezar added the must-backport The changes in PR need to be backported to at least one stable release branch. label Oct 11, 2024
@elezar elezar self-assigned this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
must-backport The changes in PR need to be backported to at least one stable release branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The mounts discoverer cache usage is racey
1 participant