Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -z,lazy to LDFLAGS #732

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Add -z,lazy to LDFLAGS #732

merged 1 commit into from
Oct 11, 2024

Conversation

elezar
Copy link
Member

@elezar elezar commented Oct 10, 2024

This fixes undefined symbol errors on platforms where -z,lazy may not be the default.

This was inadvertently removed in #333 and replaced with -Wl,--export-dynamic -Wl,--unresolved-symbols=ignore-in-object-files which seems to be equivalent on some systems.

@elezar elezar self-assigned this Oct 10, 2024
@klueska
Copy link
Contributor

klueska commented Oct 10, 2024

Is it an either/or with --unresolved-symbols=ignore-in-object-files and -z,lazy or is it OK on all platforms to have both?

@elezar
Copy link
Member Author

elezar commented Oct 10, 2024

Is it an either/or with --unresolved-symbols=ignore-in-object-files and -z,lazy or is it OK on all platforms to have both?

I can't make a comment on all platforms. From my testing, it works on Ubuntu, but let me check the documentation.

Update: The ld man pages don't mention any connection between the two options. Note it does also state that -z lazy is the default, but it may be that this option is being affected by some config that is set on Gentoo.

@elezar elezar requested a review from klueska October 10, 2024 12:39
@elezar elezar added the must-backport The changes in PR need to be backported to at least one stable release branch. label Oct 11, 2024
@elezar elezar mentioned this pull request Oct 11, 2024
This fixes undefined symbol errors on platforms where -z,lazy may
not be the default.

Signed-off-by: Evan Lezar <[email protected]>
@elezar elezar merged commit 7fb31bd into NVIDIA:main Oct 11, 2024
13 checks passed
@elezar elezar linked an issue Oct 11, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
must-backport The changes in PR need to be backported to at least one stable release branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nvidia-ctk returns undefined symbol: nvmlComputeInstanceDestroy
2 participants