-
Notifications
You must be signed in to change notification settings - Fork 288
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[no-relnote] Refactor driver library discovery
This change aligns the driver file discovery with device discovery and allows other sources such as nvsandboxutils to be added. Signed-off-by: Evan Lezar <[email protected]>
- Loading branch information
Showing
7 changed files
with
182 additions
and
49 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/** | ||
# Copyright (c) NVIDIA CORPORATION. All rights reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
**/ | ||
|
||
package dgpu | ||
|
||
import ( | ||
"fmt" | ||
|
||
"github.com/NVIDIA/nvidia-container-toolkit/internal/discover" | ||
) | ||
|
||
// newNvsandboxutilsDriverDiscoverer constructs a discoverer from the specified nvsandboxutils library. | ||
func (o *options) newNvsandboxutilsDriverDiscoverer() (discover.Discover, error) { | ||
if o.nvsandboxutilslib == nil { | ||
return nil, nil | ||
} | ||
return nil, fmt.Errorf("nvsandboxutils driver discovery is not implemented") | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
/** | ||
# Copyright (c) NVIDIA CORPORATION. All rights reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
**/ | ||
|
||
package dgpu | ||
|
||
import ( | ||
"errors" | ||
"fmt" | ||
|
||
"github.com/NVIDIA/nvidia-container-toolkit/internal/discover" | ||
) | ||
|
||
// NewDriverDiscoverer creates a discoverer for the libraries and binaries associated with a driver installation. | ||
func NewDriverDiscoverer(opts ...Option) (discover.Discover, error) { | ||
o := new(opts...) | ||
|
||
if o.version == "" { | ||
return nil, fmt.Errorf("a version must be specified") | ||
} | ||
|
||
var discoverers []discover.Discover | ||
var errs error | ||
|
||
nvsandboxutilsDiscoverer, err := o.newNvsandboxutilsDriverDiscoverer() | ||
if err != nil { | ||
// TODO: Log a warning | ||
errs = errors.Join(errs, err) | ||
} else if nvsandboxutilsDiscoverer != nil { | ||
discoverers = append(discoverers, nvsandboxutilsDiscoverer) | ||
} | ||
|
||
nvmlDiscoverer, err := o.newNvmlDriverDiscoverer() | ||
if err != nil { | ||
// TODO: Log a warning | ||
errs = errors.Join(errs, err) | ||
} else if nvmlDiscoverer != nil { | ||
discoverers = append(discoverers, nvmlDiscoverer) | ||
} | ||
|
||
if len(discoverers) == 0 { | ||
return nil, errs | ||
} | ||
|
||
cached := discover.WithCache( | ||
discover.FirstValid( | ||
discoverers..., | ||
), | ||
) | ||
updateLDCache, _ := discover.NewLDCacheUpdateHook(o.logger, cached, o.nvidiaCDIHookPath, o.ldconfigPath) | ||
|
||
ipcs, err := discover.NewIPCDiscoverer(o.logger, o.driver.Root) | ||
if err != nil { | ||
return nil, fmt.Errorf("failed to create discoverer for IPC sockets: %v", err) | ||
} | ||
|
||
return discover.Merge( | ||
cached, | ||
updateLDCache, | ||
ipcs, | ||
), nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters