Require that LIB_VERSION be set as make variable

Since this package is built / released as part of the NVIDIA Container Toolkit, bumping the version in this repository causes unnecessary churn. This change REQUIRES that the LIB_VERSION be set as a make variable or in CI. Signed-off-by: Evan Lezar <[email protected]>
NVIDIA · Nov 30, 2021 · 5d7c66a · 5d7c66a
1 parent 35a9761
commit 5d7c66a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
@@ -5,10 +5,12 @@ stages:
   - build-all
 
 variables:
-  # We specify the TOOLKIT_VERSION and TOOLKIT_TAG variable to allow packages
+  # We specify the LIB_VERSION, TOOLKIT_VERSION, and TOOLKIT_TAG variable to allow packages
   # to be built.
+  LIB_VERSION: 999.999.999
+  LIB_TAG: dummy+lib
   TOOLKIT_VERSION: 999.999.999
-  TOOLKIT_TAG: dummy
+  TOOLKIT_TAG: dummy+toolkit
 
 .build-setup: &build-setup
   image: docker:19.03.8

diff --git a/Makefile b/Makefile
@@ -13,8 +13,15 @@
 # limitations under the License.
 
 LIB_NAME := nvidia-container-runtime
-LIB_VERSION := 3.7.0
-LIB_TAG ?= rc.1
+# Define the package version and tag. Since this package is released as part of
+# the NVIDIA Container Toolkit, these versions are specified where they are
+# built or when invoking the MAKE command.
+LIB_VERSION ?= # Set by CI
+LIB_TAG ?= # Set by CI
+
+ifeq ($(strip $(LIB_VERSION)),)
+$(error LIB_VERSION must be specified)
+endif
 
 # Define the nvidia-container-toolkit version on which the nvidia-docker2
 # package depends. It is recommended that the TOOLKIT_TAG and the LIB_TAG match.