Prevent CI coverage from failing prematurely#50
Merged
laserkelvin merged 3 commits intoNVIDIA:mainfrom Apr 3, 2026
Merged
Conversation
Signed-off-by: Kelvin Lee <kinlongkelvi@nvidia.com>
Contributor
Greptile SummaryThis PR fixes premature CI coverage failures on PR runs by setting Important Files Changed
Reviews (3): Last reviewed commit: "ci: trying to make it even more explicit" | Re-trigger Greptile |
Collaborator
Author
|
/ok to test 7f4dc29 |
9 tasks
Signed-off-by: Kelvin Lee <kinlongkelvi@nvidia.com>
Collaborator
Author
|
/ok to test d92783d |
Signed-off-by: Kelvin Lee <kinlongkelvi@nvidia.com>
Collaborator
Author
|
/ok to test 917f70e |
dallasfoster
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALCHEMI Toolkit Pull Request
Description
This PR changes the "Run selective tests (PR)" stage of the CI workflow to not fail on coverage when running the reduced set of unit tests.
This stage instead produces a more compact set of coverage information, which is then in the later reporting step combined with the baseline coverage information. Failing due to insufficient coverage should then only happen (as originally intended) at the "Check coverage threshold (PR only)" stage.
Type of Change
Related Issues
PR #46 was failing due to this issue
Changes Made
Testing
make pytest)make lint)Checklist
Additional Notes
Tip
This repository uses Greptile, an AI code review service, to help conduct
pull request reviews. We encourage contributors to read and consider suggestions
made by Greptile, but note that human maintainers will provide the necessary
reviews for merging: Greptile's comments are not a qualitative judgement
of your code, nor is it an indication that the PR will be accepted/rejected.
We encourage the use of emoji reactions to Greptile comments, depending on
their usefulness and accuracy.