Skip to content

Prevent CI coverage from failing prematurely#50

Merged
laserkelvin merged 3 commits intoNVIDIA:mainfrom
laserkelvin:testmon-ci-coverage-order-fix
Apr 3, 2026
Merged

Prevent CI coverage from failing prematurely#50
laserkelvin merged 3 commits intoNVIDIA:mainfrom
laserkelvin:testmon-ci-coverage-order-fix

Conversation

@laserkelvin
Copy link
Copy Markdown
Collaborator

ALCHEMI Toolkit Pull Request

Description

This PR changes the "Run selective tests (PR)" stage of the CI workflow to not fail on coverage when running the reduced set of unit tests.

This stage instead produces a more compact set of coverage information, which is then in the later reporting step combined with the baseline coverage information. Failing due to insufficient coverage should then only happen (as originally intended) at the "Check coverage threshold (PR only)" stage.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement
  • Documentation update
  • Refactoring (no functional changes)
  • CI/CD or infrastructure change

Related Issues

PR #46 was failing due to this issue

Changes Made

  • Made reduced coverage test run not fail on lack of coverage

Testing

  • Unit tests pass locally (make pytest)
  • Linting passes (make lint)
  • New tests added for new functionality meets coverage expectations?

Checklist

  • I have read and understand the Contributing Guidelines
  • I have updated the CHANGELOG.md
  • I have performed a self-review of my code
  • I have added docstrings to new functions/classes
  • I have updated the documentation (if applicable)

Additional Notes

Tip

This repository uses Greptile, an AI code review service, to help conduct
pull request reviews. We encourage contributors to read and consider suggestions
made by Greptile, but note that human maintainers will provide the necessary
reviews for merging: Greptile's comments are not a qualitative judgement
of your code, nor is it an indication that the PR will be accepted/rejected.
We encourage the use of emoji reactions to Greptile comments, depending on
their usefulness and accuracy.

Signed-off-by: Kelvin Lee <kinlongkelvi@nvidia.com>
@laserkelvin laserkelvin requested a review from dallasfoster April 3, 2026 01:08
@laserkelvin laserkelvin added the bug Something isn't working label Apr 3, 2026
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Apr 3, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 3, 2026

Greptile Summary

This PR fixes premature CI coverage failures on PR runs by setting --cov-fail-under=0 during selective test execution and routing threshold enforcement exclusively through the shared "Check coverage threshold" step. The refactor also unifies coverage reporting for both full runs and PR runs into common steps, and replaces make testmon-coverage with a direct uv run pytest invocation on the full-run path. The logic is sound and the intent is well-executed.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Refactors coverage reporting into shared steps and disables fail-under during the selective PR test run; logic is mostly sound but one edge case around testmon selecting zero tests warrants attention.

Reviews (3): Last reviewed commit: "ci: trying to make it even more explicit" | Re-trigger Greptile

@laserkelvin
Copy link
Copy Markdown
Collaborator Author

/ok to test 7f4dc29

Signed-off-by: Kelvin Lee <kinlongkelvi@nvidia.com>
@laserkelvin
Copy link
Copy Markdown
Collaborator Author

/ok to test d92783d

Signed-off-by: Kelvin Lee <kinlongkelvi@nvidia.com>
@laserkelvin
Copy link
Copy Markdown
Collaborator Author

/ok to test 917f70e

@laserkelvin laserkelvin added this pull request to the merge queue Apr 3, 2026
Merged via the queue into NVIDIA:main with commit 74a4abe Apr 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants