Conversation
Signed-off-by: Kelvin Lee <kinlongkelvi@nvidia.com>
Signed-off-by: Kelvin Lee <kinlongkelvi@nvidia.com>
Greptile SummaryThis PR removes the
Important Files Changed
Reviews (1): Last reviewed commit: "docs: descriptions" | Re-trigger Greptile |
| config = ZarrWriteConfig( | ||
| core=ZarrArrayConfig(compressors=(ZstdCodec(level=3),)), | ||
| ) | ||
| writer = AtomicDataZarrWriter("/data/training.zarr", config=config) | ||
| core=ZarrArrayConfig(compressors=(ZstdCodec(level=3),)), | ||
| ) | ||
| writer = AtomicDataZarrWriter("/data/example.zarr", config=config) |
There was a problem hiding this comment.
Inconsistent indentation introduced in code block
This PR changed the example path from /data/training.zarr to /data/example.zarr, but also accidentally shifted the indentation: core= now has 5 leading spaces (instead of 4) and the closing ) and writer = assignment each have a spurious leading space. The writer = line in particular visually appears to sit inside the ZarrWriteConfig(...) call. Compare with the correctly-indented Recipe 1 block at line 312.
| config = ZarrWriteConfig( | |
| core=ZarrArrayConfig(compressors=(ZstdCodec(level=3),)), | |
| ) | |
| writer = AtomicDataZarrWriter("/data/training.zarr", config=config) | |
| core=ZarrArrayConfig(compressors=(ZstdCodec(level=3),)), | |
| ) | |
| writer = AtomicDataZarrWriter("/data/example.zarr", config=config) | |
| config = ZarrWriteConfig( | |
| core=ZarrArrayConfig(compressors=(ZstdCodec(level=3),)), | |
| ) | |
| writer = AtomicDataZarrWriter("/data/example.zarr", config=config) |
ALCHEMI Toolkit Pull Request
Description
Removes residuals
Type of Change
Related Issues
Changes Made
pyproject.tomlTesting
make pytest)make lint)Checklist
Additional Notes
Tip
This repository uses Greptile, an AI code review service, to help conduct
pull request reviews. We encourage contributors to read and consider suggestions
made by Greptile, but note that human maintainers will provide the necessary
reviews for merging: Greptile's comments are not a qualitative judgement
of your code, nor is it an indication that the PR will be accepted/rejected.
We encourage the use of emoji reactions to Greptile comments, depending on
their usefulness and accuracy.