Skip to content

Conversation

@jperez999
Copy link
Collaborator

Description

This removes dependency of OpenAI for the text embedder.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • If adjusting docker-compose.yaml environment variables have you ensured those are mimicked in the Helm values.yaml file.

@jperez999 jperez999 self-assigned this Oct 15, 2025
@jperez999 jperez999 added the feature request New feature or request label Oct 15, 2025
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 15, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

# extra_body=extra_body,
# )

resp = infer_microservice(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, this really needs to be a NimClient, so that we're able to use the same configuration process that we do for all the other NIM elements.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little confused here, because this is running a NIM client. Its just surrounded by a helper function in order to make it available outside of the NIM classes. https://github.com/NVIDIA/nv-ingest/pull/1101/files#diff-134970881072236d7f90878a5b6a8676c477ff4f6814bd6f9a272b6addd85570R132 NimClient is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants