Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup debug metadata in kernel fixup #97

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

gmarkall
Copy link
Collaborator

The first kernel parameter also needs removing from the debug metadata, so that the debug metadata argument types align with the arguments to the fixed-up kernel.

Fixes #95.

The first kernel parameter also needs removing from the debug metadata,
so that the debug metadata argument types align with the arguments to
the fixed-up kernel.
@gmarkall gmarkall added the 2 - In Progress Currently a work in progress label Dec 20, 2024
@gmarkall
Copy link
Collaborator Author

This could do with some tests adding.

@gmarkall gmarkall added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Feb 19, 2025
@gmarkall gmarkall merged commit 7c60679 into NVIDIA:main Feb 20, 2025
31 checks passed
gmarkall added a commit to gmarkall/numba-cuda that referenced this pull request Mar 6, 2025
- Fix linking of external code from callees (NVIDIA#137)
- Try using a newer branch workflow (NVIDIA#148)
- Move publish step out of `wheels-build.yaml` (NVIDIA#147)
- Upload wheels to PyPI from GitHub-hosted runner (NVIDIA#142)
- Add paddle to interoperability chapter (NVIDIA#144)
- Fix the debug info of GridGroup type (NVIDIA#131)
- Remove dead `prepare_cuda_kernel()` (NVIDIA#130)
- Add a CUDA DI Builder (NVIDIA#104)
- dont launch extra kernels when stats counting is disabled (NVIDIA#127)
- Fixup debug metadata in kernel fixup (NVIDIA#97)
- Implement debuginfo bool name fix (numba/numba#9888) in numba-cuda (NVIDIA#106)
@gmarkall gmarkall mentioned this pull request Mar 6, 2025
gmarkall added a commit that referenced this pull request Mar 6, 2025
- Fix linking of external code from callees (#137)
- Try using a newer branch workflow (#148)
- Move publish step out of `wheels-build.yaml` (#147)
- Upload wheels to PyPI from GitHub-hosted runner (#142)
- Add paddle to interoperability chapter (#144)
- Fix the debug info of GridGroup type (#131)
- Remove dead `prepare_cuda_kernel()` (#130)
- Add a CUDA DI Builder (#104)
- dont launch extra kernels when stats counting is disabled (#127)
- Fixup debug metadata in kernel fixup (#97)
- Implement debuginfo bool name fix (numba/numba#9888) in numba-cuda (#106)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Kernel fixup does not adjust debug metadata arguments
2 participants