Fixup debug metadata in kernel fixup #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first kernel parameter also needs removing from the debug metadata, so that the debug metadata argument types align with the arguments to the fixed-up kernel.
|
This could do with some tests adding. |
gmarkall
added
3 - Ready for Review
gmarkall
added a commit
to gmarkall/numba-cuda
that referenced
this pull request
Mar 6, 2025
- Fix linking of external code from callees (NVIDIA#137) - Try using a newer branch workflow (NVIDIA#148) - Move publish step out of `wheels-build.yaml` (NVIDIA#147) - Upload wheels to PyPI from GitHub-hosted runner (NVIDIA#142) - Add paddle to interoperability chapter (NVIDIA#144) - Fix the debug info of GridGroup type (NVIDIA#131) - Remove dead `prepare_cuda_kernel()` (NVIDIA#130) - Add a CUDA DI Builder (NVIDIA#104) - dont launch extra kernels when stats counting is disabled (NVIDIA#127) - Fixup debug metadata in kernel fixup (NVIDIA#97) - Implement debuginfo bool name fix (numba/numba#9888) in numba-cuda (NVIDIA#106)
Merged
gmarkall
added a commit
that referenced
this pull request
Mar 6, 2025
- Fix linking of external code from callees (#137) - Try using a newer branch workflow (#148) - Move publish step out of `wheels-build.yaml` (#147) - Upload wheels to PyPI from GitHub-hosted runner (#142) - Add paddle to interoperability chapter (#144) - Fix the debug info of GridGroup type (#131) - Remove dead `prepare_cuda_kernel()` (#130) - Add a CUDA DI Builder (#104) - dont launch extra kernels when stats counting is disabled (#127) - Fixup debug metadata in kernel fixup (#97) - Implement debuginfo bool name fix (numba/numba#9888) in numba-cuda (#106)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first kernel parameter also needs removing from the debug metadata, so that the debug metadata argument types align with the arguments to the fixed-up kernel.
Fixes #95.