Allow Adding External Linkage through Target Context #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarkall
added
3 - Ready for Review
isVoid
added
DO NOT MERGE
|
Offline discussion: we should roll this PR into #166 and use that PR as a test. |
isVoid
added a commit
to isVoid/numba-cuda
that referenced
this pull request
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a few iterations offline, we discovered that Numbast cannot pass the external information by either overriding typing or lowering behavior. We discovered that the simplest to unblock Numbast from compilation based on inferred usage is by adding them to the target context at lower time.