-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.13, and update shared-workflows. #150
base: main
Are you sure you want to change the base?
Conversation
@gmarkall It'd be great to have your eyes on some of these failures. Are any of them expected? |
@bdice Thanks for the PR! These are not expected, but they all seem to have a common cause - I'll take a look. |
We will need rapidsai/pynvjitlink#131 and a pynvjitlink release to unblock Python 3.13 tests. That PR is ready and just needs a final review, so I think a new release might be able to ship today. If the other segfault issues on this PR are worked out before that release, we can temporarily roll those jobs back to Python 3.12. |
I fixed up the CI matrix and made sure we have supported image tags across the matrix. I think there are only two root causes of the CI failures to address. The conda CUDA 11.4 job is showing:
The CUDA 12.8 / Python 3.13 jobs (for conda and wheels and pynvjitlink) are showing a segfault in
|
The failing tests are net-new coverage in the test suite. I would like to propose breaking this down, to make solving the issues easier and more atomic.
|
Update: the segfault still occurs with Python 3.12. Maybe the segfault wasn't due to Python 3.13, perhaps it was something with the OS (ubuntu24.04) or CUDA version (12.8.0). I will try another combination of matrix options to isolate what is causing this. |
pynvjitlink 0.5.1 is released, with Python 3.13 support. There is one test failure remaining on the conda pynvjitlink job:
I am trying to rerun the job but I suspect this will need further investigation. |
This PR adds Python 3.13 to CI, and updates the workflows to align with updates from RAPIDS'
shared-workflows
upstream.