feat(auth): grant RLA permission to SetMaintenance#792
Merged
kunzhao-nv merged 7 commits intoNVIDIA:mainfrom Apr 3, 2026
Merged
feat(auth): grant RLA permission to SetMaintenance#792kunzhao-nv merged 7 commits intoNVIDIA:mainfrom
kunzhao-nv merged 7 commits intoNVIDIA:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Allows the internal Rla caller principal to invoke the SetMaintenance RPC, aligning SetMaintenance authorization with other RLA-authorized operations.
Changes:
- Add
Rlato the allowed principals list for theSetMaintenancepermission in internal RBAC rules.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kunzhao-nv
force-pushed
the
kunzhao/add-rla-set-maintenance
branch
from
ea6ebd8 to
dd273a5
Compare
kunzhao-nv
requested review from
aswaroop-nv,
ddejong-spec,
jw-nvidia and
spydaNVIDIA
zhaozhongn
approved these changes
Apr 2, 2026
spydaNVIDIA
approved these changes
Apr 2, 2026
Contributor
|
SetMaintenance is marked as deprecated and replaced by health-override APIs. You should use the latter. |
Allow the Rla internal caller to invoke SetMaintenance, aligning it with other RLA-authorized operations like TriggerHostReprovisioning. Signed-off-by: Kun Zhao <kunzhao@nvidia.com>
kunzhao-nv
force-pushed
the
kunzhao/add-rla-set-maintenance
branch
from
dd273a5 to
a2a0ce4
Compare
kunzhao-nv
changed the title
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-04-02 21:22:21 UTC | Commit: d20dc3f |
Add Rla to InsertHealthReportOverride and RemoveHealthReportOverride, which are the preferred APIs over the legacy SetMaintenance wrapper. Signed-off-by: Kun Zhao <kunzhao@nvidia.com>
kunzhao-nv
force-pushed
the
kunzhao/add-rla-set-maintenance
branch
from
d20dc3f to
9f3cbcb
Compare
Contributor
Author
Thanks for the info. Grant access for those apis as well. |
spydaNVIDIA
approved these changes
Apr 2, 2026
ddejong-spec
approved these changes
Apr 2, 2026
aswaroop-nv
approved these changes
Apr 2, 2026
wminckler
pushed a commit
to wminckler/ncx-infra-controller-core
that referenced
this pull request
Apr 3, 2026
Allow the RLA internal caller to invoke SetMaintenance, aligning it with other RLA-authorized operations. This is a prerequisite to trigger power off api. Signed-off-by: Kun Zhao <kunzhao@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow the RLA internal caller to invoke SetMaintenance, aligning it with other RLA-authorized operations. This is a prerequisite to trigger power off api.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes