Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes pro first release cut #13

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Minor fixes pro first release cut #13

merged 4 commits into from
Feb 15, 2024

Conversation

ArangoGutierrez
Copy link
Collaborator

Fixes #10
Fixes #11

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but they're not blockers.

api/holodeck/v1alpha1/types.go Outdated Show resolved Hide resolved
api/holodeck/v1alpha1/types.go Outdated Show resolved Hide resolved
api/holodeck/v1alpha1/types.go Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez ArangoGutierrez merged commit 3957e15 into main Feb 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec should refer to nvidiaDriver instead of nvDriver Spec should refer to nvidiaContainerToolkit
2 participants