update base image to the ubi9 variant #937
Conversation
tariq1890
requested review from
ArangoGutierrez,
cdesiniotis,
elezar and
shivamerla
as code owners
tariq1890
force-pushed
the
ubi9-base
branch
4 times, most recently
from
c46bd17 to
cc79801
Compare
tariq1890
force-pushed
the
ubi9-base
branch
2 times, most recently
from
5ec173b to
9f932c8
Compare
|
@cdesiniotis I have reverted the CUDA_SAMPLES image bump and rebased the PR |
| @@ -237,9 +237,9 @@ jobs: | |||
| LOWERCASE_REPO_OWNER=$(echo "${GITHUB_REPOSITORY_OWNER}" | awk '{print tolower($0)}') | |||
| echo "LOWERCASE_REPO_OWNER=$(echo "${GITHUB_REPOSITORY_OWNER}" | awk '{print tolower($0)}')" >> $GITHUB_ENV | |||
|
|
|||
| echo "OPERATOR_VERSION=${COMMIT_SHORT_SHA}-ubi8" >> $GITHUB_ENV | |||
| echo "OPERATOR_VERSION=${COMMIT_SHORT_SHA}-ubi9" >> $GITHUB_ENV | |||
There was a problem hiding this comment.
Note: Since we only provide one flavour of image we could just drop the -ubi9 suffix.
There was a problem hiding this comment.
Agreed. I am assuming there is a rationale behind the ubi8 suffix? If it's safe enough to drop it, I am all for the change
There was a problem hiding this comment.
@cdesiniotis @shivamerla thoughts on this?
There was a problem hiding this comment.
yeah, safe to drop ubi suffix as we don't reference those tags in the Helm charts or OLM.
There was a problem hiding this comment.
@elezar Looks like I'll have to make changes in multiple places to drop the DIST suffix. I'd like to make that change in a follow-up PR.
I'd like to limit the changeset to ubi9 upgrade in this PR
| @@ -97,7 +97,7 @@ COPY deployments/gpu-operator/charts/node-feature-discovery/crds/nfd-api-crds.ya | |||
| # Install / upgrade packages here that are required to resolve CVEs | |||
| ARG CVE_UPDATES | |||
There was a problem hiding this comment.
In general, I would recommend removing this block entirely. We have largely stopped using this envvar across our projects -- especially since we've streamlined our waiver process.
There was a problem hiding this comment.
Yes, agreed . I think this block was added as a stopgap to quickly fix CVEs at the time
There was a problem hiding this comment.
I can make this change in a follow up PR
| @@ -87,7 +87,7 @@ LABEL vsc-ref=${GIT_COMMIT} | |||
| # Install / upgrade packages here that are required to resolve CVEs | |||
| ARG CVE_UPDATES | |||
There was a problem hiding this comment.
Same here on removing the block.
Signed-off-by: Tariq Ibrahim <[email protected]>
No description provided.