controller-runtime cache should only list-watch resources in the operator namespace #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tariq1890
requested review from
ArangoGutierrez,
cdesiniotis,
elezar and
shivamerla
as code owners
cdesiniotis
approved these changes
Aug 1, 2024
cdesiniotis
reviewed
Aug 2, 2024
…ator namespace Signed-off-by: Tariq Ibrahim <[email protected]> add openshift namespace to the controller-runtime cache Signed-off-by: Tariq Ibrahim <[email protected]>
cdesiniotis
approved these changes
Aug 2, 2024
mikemckiernan
added a commit
to mikemckiernan/cloud-native-docs
that referenced
this pull request
Oct 31, 2024
CNT-5289 Documents: - NVIDIA/gpu-operator#890 - NVIDIA/gpu-operator#986 Signed-off-by: Mike McKiernan <[email protected]>
mikemckiernan
added a commit
to NVIDIA/cloud-native-docs
that referenced
this pull request
Oct 31, 2024
* Update Kubernetes supported versions Documents CNT-5342 * Support for Net Op 24.7.0 Documents CNT-5346 * MIG profiles for GH200 144GB HBM3e Documents NVIDIA/gpu-operator#1057. * Troubleshooting taints and tolerations * Tolerations for clean up and upgrade CRD jobs Documents these PRs: - NVIDIA/gpu-operator#967 - NVIDIA/gpu-operator#960 * RBAC improvements CNT-5289 Documents: - NVIDIA/gpu-operator#890 - NVIDIA/gpu-operator#986 * Fixed issue with CRI-O CNT-5327 Documents NVIDIA/nvidia-container-toolkit#686 * Automatic upgrade of CRDs CNT-5328 Documents NVIDIA/gpu-operator#1024 * Driver pod name and IP env vars CNT-5329 4567038 Documents NVIDIA/gpu-operator#1026 * Precompiled driver containers are GA Signed-off-by: Mike McKiernan <[email protected]> * KubeVirt and OSV vGPU v17.4 * GH200 NVL2 144GB HBM3e name * Add 565 driver * NFD version and driver container envvars Signed-off-by: Mike McKiernan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controller-runtime
Managerobject exposes thecache.Optionsstruct which contains fields used to set the caching strategy of the controller.By default, the controller's cache lists and watches namespaced-resources from all namespaces. With this change, we set the caching strategy to only list and watch for K8s resources that are created in the gpu-operator's namespace.
Note: This change only affects Kubernetes resources that have the namespace-scope. The cluster-scoped resources like Nodes, ClusterPolicy, NVIDIADriver will continue to be cached as before