Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update prometheus-operator to version v0.75.2 #878

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

ajayk
Copy link
Contributor

@ajayk ajayk commented Jul 30, 2024

No description provided.

@ArangoGutierrez
Copy link
Collaborator

Thanks for the contribution @ajayk , but for this repo we have an automated Dependabot to keep our dependencies up to date, see more at https://github.com/NVIDIA/gpu-operator/blob/main/.github/dependabot.yml#L6

@ajayk
Copy link
Contributor Author

ajayk commented Jul 30, 2024

@ArangoGutierrez dependabot had been failing due to api changes on some of the libraries this PR addresses those

@tariq1890 tariq1890 reopened this Jul 30, 2024
@tariq1890
Copy link
Contributor

Hi @ArangoGutierrez , @ajayk is correct. We need this changeset to bump the prometheus-operator dependency. While depdendabot can bump the dependencies other than the prometheus-operator, code changes are needed to be able to import the v0.75.2 version

Maybe we could just limit the changeset of this PR to bumping the prometheus-operator dependency

@ajayk ajayk force-pushed the prometheus-operator-update branch from 861bb75 to 046aef5 Compare July 30, 2024 19:39
@ajayk
Copy link
Contributor Author

ajayk commented Jul 30, 2024

Hi @ArangoGutierrez , @ajayk is correct. We need this changeset to bump the prometheus-operator dependency. While depdendabot can bump the dependencies other than the prometheus-operator, code changes are needed to be able to import the v0.75.2 version

Maybe we could just limit the changeset of this PR to bumping the prometheus-operator dependency

I have

Hi @ArangoGutierrez , @ajayk is correct. We need this changeset to bump the prometheus-operator dependency. While depdendabot can bump the dependencies other than the prometheus-operator, code changes are needed to be able to import the v0.75.2 version

Maybe we could just limit the changeset of this PR to bumping the prometheus-operator dependency

Thanks @tariq1890 I made the necessary changes just to include bumping of prometheus-operator dependency

@tariq1890
Copy link
Contributor

Thanks @ajayk !

Can you edit the commit message and retitle this PR?

update prometheus-operator to version v0.72.5

@ajayk ajayk force-pushed the prometheus-operator-update branch 2 times, most recently from d9ee835 to 8c378b2 Compare July 30, 2024 23:41
@ajayk ajayk changed the title update go dependencies update prometheus-operator to version v0.72.5 Jul 30, 2024
@ajayk
Copy link
Contributor Author

ajayk commented Jul 30, 2024

Thanks @ajayk !

Can you edit the commit message and retitle this PR?

update prometheus-operator to version v0.72.5

@tariq1890 done !!

@ajayk ajayk changed the title update prometheus-operator to version v0.72.5 update prometheus-operator to version v0.75.2 Jul 30, 2024
@ajayk ajayk force-pushed the prometheus-operator-update branch from 8c378b2 to bf77058 Compare July 30, 2024 23:43
@ajayk ajayk force-pushed the prometheus-operator-update branch from bf77058 to e4383e0 Compare July 30, 2024 23:46
@tariq1890 tariq1890 merged commit 6d3b082 into NVIDIA:main Aug 27, 2024
9 of 11 checks passed
@tariq1890
Copy link
Contributor

Thanks for your contribution @ajayk !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants