Driver persistence changes #810
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 1, 2024 22:41
Signed-off-by: Arjun <[email protected]>
JunAr7112
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
shivamerla
reviewed
Jul 3, 2024
| @@ -6,9 +6,9 @@ spec: | |||
| # use pre-compiled packages for NVIDIA driver installation. | |||
| usePrecompiled: false | |||
| driverType: gpu | |||
| repository: nvcr.io/nvidia | |||
| repository: "1837582943" #nvcr.io/nvidia | |||
There was a problem hiding this comment.
please revert this, this was required only for testing using your private image.
shivamerla
reviewed
Jul 3, 2024
| image: driver | ||
| version: "550.90.07" | ||
| version: "550.54.17" |
shivamerla
reviewed
Jul 3, 2024
| @@ -18,6 +18,8 @@ spec: | |||
| useHostMofed: false | |||
| gds: | |||
| enabled: false | |||
| persist: true | |||
There was a problem hiding this comment.
we don't want to enable this by default but only when CDI is enabled. Need to handle this in the code to error out accordingly.
shivamerla
reviewed
Jul 3, 2024
manifest.diff
Outdated
| - name: NVIDIA_VISIBLE_DEVICES | ||
| value: void | ||
| + {{- if .Driver.Spec.PersistDriver }} | ||
| + - name: RESTARTS_ENABLED |
There was a problem hiding this comment.
update this env to PERSIST_DRIVER
shivamerla
reviewed
Jul 3, 2024
| @@ -205,6 +205,12 @@ spec: | |||
| # always use runc for driver containers | |||
| - name: NVIDIA_VISIBLE_DEVICES | |||
| value: void | |||
| {{- if .Driver.Spec.PersistDriver }} | |||
| - name: RESTARTS_ENABLED | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Thanks for making this contribution! When contributing to this repository please keep in mind the following: