enable hostPID in mps-control-daemon

Signed-off-by: Tariq Ibrahim <[email protected]>
NVIDIA · Nov 18, 2024 · 88d1f96 · 88d1f96
1 parent 3fe91a3
commit 88d1f96
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/assets/state-mps-control-daemon/0400_daemonset.yaml b/assets/state-mps-control-daemon/0400_daemonset.yaml
@@ -25,6 +25,7 @@ spec:
           effect: NoSchedule
       priorityClassName: system-node-critical
       serviceAccountName: nvidia-device-plugin
+      hostPID: true
       initContainers:
         - image: "FILLED BY THE OPERATOR"
           name: toolkit-validation

diff --git a/controllers/object_controls.go b/controllers/object_controls.go
@@ -2479,9 +2479,14 @@ func handleDevicePluginConfig(obj *appsv1.DaemonSet, config *gpuv1.ClusterPolicy
 		// add configmap volume mount
 		addSharedMountsForPluginConfig(&obj.Spec.Template.Spec.Containers[i], config.DevicePlugin.Config)
 	}
-	// Enable process ns sharing for PID access
-	shareProcessNamespace := true
-	obj.Spec.Template.Spec.ShareProcessNamespace = &shareProcessNamespace
+
+	// if hostPID is already set, we skip setting the shareProcessNamespace field
+	// for context, go to https://github.com/kubernetes-client/go/blob/master/kubernetes/docs/V1PodSpec.md
+	if !obj.Spec.Template.Spec.HostPID {
+		// Enable process ns sharing for PID access
+		shareProcessNamespace := true
+		obj.Spec.Template.Spec.ShareProcessNamespace = &shareProcessNamespace
+	}
 	// add configmap volume
 	obj.Spec.Template.Spec.Volumes = append(obj.Spec.Template.Spec.Volumes, createConfigMapVolume(config.DevicePlugin.Config.Name, nil))