use constant variables in Reconciled

Signed-off-by: googs1025 <[email protected]>
NVIDIA · Dec 13, 2024 · 0fb61c3 · 0fb61c3
1 parent 9afd674
commit 0fb61c3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/controllers/nvidiadriver_controller.go b/controllers/nvidiadriver_controller.go
@@ -200,7 +200,7 @@ func (r *NVIDIADriverReconciler) Reconcile(ctx context.Context, req ctrl.Request
 		return reconcile.Result{RequeueAfter: time.Second * 5}, nil
 	}
 
-	if condErr = r.conditionUpdater.SetConditionsReady(ctx, instance, "Reconciled", "All resources have been successfully reconciled"); condErr != nil {
+	if condErr = r.conditionUpdater.SetConditionsReady(ctx, instance, conditions.Reconciled, "All resources have been successfully reconciled"); condErr != nil {
 		return ctrl.Result{}, condErr
 	}
 	return reconcile.Result{}, nil

diff --git a/internal/conditions/conditions_test.go b/internal/conditions/conditions_test.go
@@ -53,7 +53,7 @@ func TestConditionsUpdater_SetConditionsReady(t *testing.T) {
 		Reason: "Ready",
 	}
 
-	err := u.SetConditionsReady(context.Background(), driver, "Reconciled", "All resources are successfully reconciled")
+	err := u.SetConditionsReady(context.Background(), driver, Reconciled, "All resources are successfully reconciled")
 	assert.NoError(t, err)
 
 	instance := &nvidiav1alpha1.NVIDIADriver{}