Skip to content

[WIP] Include lspci in vgpu-manager image #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Include lspci in vgpu-manager image #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion vgpu-manager/rhel8/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ ENV DRIVER_VERSION=$DRIVER_VERSION
ARG DRIVER_ARCH=x86_64
ENV DRIVER_ARCH=$DRIVER_ARCH

RUN mkdir -p /driver
RUN mkdir -p /driver/rpms/pciutils
WORKDIR /driver/rpms/pciutils

RUN dnf download --resolve pciutils && dnf clean all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just install the rpm package instead of downloading it and running it later?

Do we want to use pciutils in the DTK container? If so, we should consider baking pciutils into DTK

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, currently lspci is needed at runtime by the sriov-manage script that we invoke in the DTK container. Vitaly asked the DTK team if they could include the pciutils package in the DTK image, but they said no.


WORKDIR /driver
COPY NVIDIA-Linux-${DRIVER_ARCH}-${DRIVER_VERSION}-vgpu-kvm.run .
RUN chmod +x NVIDIA-Linux-${DRIVER_ARCH}-${DRIVER_VERSION}-vgpu-kvm.run
Expand Down
2 changes: 1 addition & 1 deletion vgpu-manager/rhel8/ocp_dtk_entrypoint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ dtk-build-driver() {

# ensure lspci is installed, as 'sriov-manage' script requires it
if ! $(lspci >/dev/null); then
dnf install -y pciutils && rm -rf /var/cache/yum/*
rpm -ivh ${DRIVER_TOOLKIT_SHARED_DIR}/driver/rpms/pciutils/*.rpm
fi

# upon catching a signal, terminate child process to trigger driver cleanup
Expand Down