Skip to content

USE GIT_COMMIT in container builds #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

USE GIT_COMMIT in container builds #255

wants to merge 1 commit into from

Conversation

cdesiniotis
Copy link
Contributor

@cdesiniotis cdesiniotis commented Mar 9, 2025 •
edited
Loading 

$ regctl image inspect ghcr.io/nvidia/driver:eac3fe8c-570.124.06-ubuntu22.04 --format '{{ jsonPretty .Config.Labels }}'
{
  "com.nvidia.git-commit": "eac3fe8c7c066ebffb41a5592eedfc1dd36d7891",
  "description": "See summary",
  "io.k8s.display-name": "NVIDIA Driver Container",
  "maintainer": "NVIDIA CORPORATION <[email protected]>",
  "name": "NVIDIA Driver Container",
  "org.opencontainers.image.ref.name": "ubuntu",
  "org.opencontainers.image.version": "22.04",
  "release": "N/A",
  "summary": "Provision the NVIDIA driver through containers",
  "vendor": "NVIDIA",
  "version": "570.124.06"
}

@cdesiniotis
USE GIT_COMMIT in container builds
6feead4 
Signed-off-by: Christopher Desiniotis <[email protected]>
shivakunv
shivakunv approved these changes Mar 9, 2025
View reviewed changes
Copy link
Contributor

@shivakunv shivakunv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tariq1890
tariq1890 reviewed Mar 10, 2025
View reviewed changes
ubuntu20.04/Dockerfile
LABEL name="NVIDIA Driver Container"
LABEL vendor="NVIDIA"
LABEL version="${DRIVER_VERSION}"
LABEL com.nvidia.git-commit="${GIT_COMMIT}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd classify git-commit under generic metadata similar to name, vendor, version. let's drop the com.nvidia prefix

@cdesiniotis cdesiniotis marked this pull request as draft March 26, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tariq1890 tariq1890 tariq1890 left review comments

@shivakunv shivakunv shivakunv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cdesiniotis @tariq1890 @shivakunv