ubuntu24.04 precompile image support #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivakunv
force-pushed
the
ci-precompile-ubuntu24.04
branch
11 times, most recently
from
889faa3 to
3da86d9
Compare
shivakunv
force-pushed
the
ci-precompile-ubuntu24.04
branch
7 times, most recently
from
b418b0e to
e13c517
Compare
shivakunv
force-pushed
the
ci-precompile-ubuntu24.04
branch
3 times, most recently
from
4ff0a56 to
ae1b88d
Compare
|
@shivakunv #124 has been merged. Please rebase off the latest main branch. |
shivakunv
force-pushed
the
ci-precompile-ubuntu24.04
branch
6 times, most recently
from
3447b5f to
a5d1911
Compare
shivakunv
force-pushed
the
ci-precompile-ubuntu24.04
branch
2 times, most recently
from
2ac52e6 to
af89f33
Compare
shivakunv
commented
Nov 22, 2024
shivakunv
commented
Nov 22, 2024
shivakunv
force-pushed
the
ci-precompile-ubuntu24.04
branch
from
dfdfd1b to
9260c8f
Compare
shivakunv
changed the title
shivakunv
force-pushed
the
ci-precompile-ubuntu24.04
branch
from
4cd78ec to
ad6a4f9
Compare
shivakunv
commented
Nov 25, 2024
shivakunv
commented
Nov 25, 2024
shivakunv
commented
Nov 25, 2024
cdesiniotis
reviewed
Nov 26, 2024
shivakunv
force-pushed
the
ci-precompile-ubuntu24.04
branch
from
ad6a4f9 to
17818dc
Compare
shivakunv
commented
Nov 26, 2024
shivakunv
force-pushed
the
ci-precompile-ubuntu24.04
branch
5 times, most recently
from
8fb7f9d to
ad111f3
Compare
shivakunv
commented
Nov 27, 2024
shivakunv
force-pushed
the
ci-precompile-ubuntu24.04
branch
from
ad111f3 to
5bb4eea
Compare
cdesiniotis
reviewed
Dec 2, 2024
| regctl image get-file ghcr.io/nvidia/driver:base-${BASE_TARGET}-${KERNEL_FLAVOR}-${DRIVER_BRANCH} /var/kernel_version.txt ./kernel_version.txt | ||
| export $(grep -oP 'KERNEL_VERSION=[^ ]+' ./kernel_version.txt) | ||
| regctl image get-file ghcr.io/nvidia/driver:base-${BASE_TARGET}-${KERNEL_FLAVOR}-${DRIVER_BRANCH} /var/kernel_version.txt ./kernel_version.txt 2>/dev/null || true | ||
| if [[ -f ./kernel_version.txt && -s ./kernel_version.txt ]]; then |
There was a problem hiding this comment.
As discussed offline, let's see if we can remove this conditional logic as we are building the base image in a previous step in this workflow.
There was a problem hiding this comment.
this require pushing of base image.
TODO: follow up added
Signed-off-by: shiva kumar <[email protected]>
shivakunv
force-pushed
the
ci-precompile-ubuntu24.04
branch
from
5bb4eea to
8cec607
Compare
|
skip_remaining removed for azure and exclude_matrix_values for azure kernel version added |
cdesiniotis
reviewed
Dec 5, 2024
cdesiniotis
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.