Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream rebase #31

Closed
wants to merge 113 commits into from
Closed

Upstream rebase #31

wants to merge 113 commits into from

Conversation

filanov
Copy link
Collaborator

@filanov filanov commented Nov 24, 2024


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

jcastill and others added 30 commits July 4, 2024 08:19
Capture debug and features files from
/sys/kernel/debug/sched/

Related: RHEL-44353

Signed-off-by: Jose Castillo <[email protected]>
In Kubernetes/OpenShift rotated logs have no symbolic link in
/var/log/containers and they cannot be retrieved using `oc logs` either,
so there is no way to get these rotated logs in a SOS report.

This patch proposes extending the `container_log` plugin to make it also
capable of retrieving rotated logs from `var/log/pods` using a plugin
boolean option called `rotated`.

Closes sosreport#3677
Signed-off-by: Gorka Eguileor <[email protected]>
To prevent avocado hiccups that slow down sos execution, let disable
debug logs to stdout.

Resolves: sosreport#3693

Signed-off-by: Pavel Moravec <[email protected]>
* Add function collect_kinit, to get the kinit output for diff id_provider
* hostname variable to get hostname with FQDN
* Use of re.match to identify id_provider
* add comment with explanation of 15 characters Hostname

Signed-off-by: rbelokar <[email protected]>
The snap can be build on 22.04 in the workflow as the action creates
the relevant versioned container and builds the snap

Closes: sosreport#3696
Signed-off-by: Arif Ali <[email protected]>
Current output of this command without a path is:

```
Invalid command: missing required parameter root(<string>)
dump tree <root> [<depth:int>] :  dump metadata cache for subtree
admin_socket: invalid command
```

Signed-off-by: Jake Nabasny <[email protected]>
When using rpm-ostree, /boot/config-{release} doesn't exists
but RHEL/Fedora family also ship the kernel config file
in /lib/modules/{release}/config, so try that as fallback.

Signed-off-by: Etienne Champetier <[email protected]>
Previous environment tests did not have ceilometer, and testing on new
version brought out this issue.

Also solved the hooks.log obfuscation

Resolves: sosreport#3713

Co-authored-by: David Negreira <[email protected]>
Signed-off-by: Arif Ali <[email protected]>
Signed-off-by: David Negreira <[email protected]>
Signed-off-by: Ponnuvel Palaniyappan <[email protected]>
Signed-off-by: Ponnuvel Palaniyappan <[email protected]>
Signed-off-by: Ponnuvel Palaniyappan <[email protected]>
Capture authselect config file

Related: RHEL-48608

Signed-off-by: Jose Castillo <[email protected]>
Capture 'nmstatectl show' and 'nmstatectl show --running-config'

Related: RHEL-50639

Signed-off-by: Jose Castillo <[email protected]>
The following are enabled:
  - consider-using-in
  - superfluous-parens
  - no-else-raise
  - useless-object-inheritance
  - consider-using-sys-exit

Signed-off-by: Ponnuvel Palaniyappan <[email protected]>
Capture two files from /sys/kernel/memory/lru_gen:
- enabled
- min_ttl_ms

Related: RHEL-50917

Signed-off-by: Jose Castillo <[email protected]>
  - possibly-used-before-assignment
  - use-a-generator

Signed-off-by: Ponnuvel Palaniyappan <[email protected]>
  - modified-iterating-list
  - cell-var-from-loop
  - use-implicit-booleaness-not-len
  - try-except-raise
  - use-implicit-booleaness-not-comparison

Signed-off-by: Ponnuvel Palaniyappan <[email protected]>
- plugin_timeout = 1800 (because journal collection takes time)
- collect journal for all MAAS related services (by default since yesterday)
- mask passwords in (conf|yaml|yml|toml) files with `do_path_regex_sub`
- collect only recent syslog data for machines (if `--all-logs` was not provided)

snap:
- collect all `.conf` and `.yaml` files
- exclude files containing secrets and keys under `/var/snap/maas/**`

deb:
- add missing service `maas-temporal-worker` introduced in MAAS 3.5
- collect `/var/lib/maas/temporal`
- use glob pattern to collect `.conf` files
- exclude secrets and keys under `/var/lib/maas/**` and `/etc/maas/**`
- remove `/var/log/upstart/maas-*` as it was removed in xenial
- remove `maas-region dumpdata` as it can expose sensitive information

Signed-off-by: Anton Troyanov <[email protected]>
filanov and others added 28 commits November 24, 2024 12:48
updating because of blackduck check
adding sos to obsolete

adding sos-mlx-cloud-verification.conf to rpm build
When installing rpm in rhel there are conflicts on existing files
To avoid this conflict spec install step will remove the existing
files and replace them with the new version
It is incorrect to change files of other packages.
The resolution should be to obsolete the existing sos package names.
This reverts commit e50d6da.

Signed-off-by: Roi Dayan <[email protected]>
sos-collector only exists up to version 1.9 so leave as is.
Obsolete any sos package for any version.
Still set provides sos to support any existing 3rd party
packages that could look for sos package.

Fixes: aa7ca3b ("Fix rpm conflict with sos")
Signed-off-by: Roi Dayan <[email protected]>
Signed-off-by: Michael Filanov <[email protected]>
Signed-off-by: Majd Dibbiny <[email protected]>
Signed-off-by: Michael Filanov <[email protected]>
Signed-off-by: Maor Dickman <[email protected]>
Reverting mlx5_core plugin as it cause kernel panic
when running on BF arm.
Will re-enable it after the driver fix this issue.

Issue: 3998589
This reverts commit f79e89a.
on deb doca ovs called doca-openvswitch-switch
HBN stand for a host based networking
Reenable mlx5_core plugin as the mlx5 driver was fixed and
it doesn't crash from doca 2.8 version.

This reverts commit 732995a.

Signed-off-by: Maor Dickman <[email protected]>
Add dpctl commands: dpctl/cache-get-size, dpctl/ct-bkts,
dpctl/ct-get-limits, dpctl/ct-get-maxconns, dpctl/ct-get-nconns,
dpctl/ct-get-sweep-interval, dpctl/ct-get-tcp-seq-chk,
dpctl/dump-conntrack-exp, dpctl/offload-stats-show.

Signed-off-by: Maor Dickman <[email protected]>
remove fwtrace - it trace HW events and can take a lot of time, not needed for debug
mstconfig -> mlxconfig otherwise command not found
mlxdump use mstdump, pcie_uc doesn't exists
set timeout to 300 seconds, some commands take a longer time to execute, the avg time to run the plugin is 55 seconds
add resourcedump command
Collect RDMA over Converged Ethernet information
The new RoCE plugin can be used to retrieve the following data for RoCE
devices:
 - counters
 - HW counters
 - ECN configuration
 - GIDs and their attributes
 - CMA configuration: TOS and mode
remove subvendor from lspci command to include all the devices
using mcra command to validate that devices are supported

some devices are not matching  0000:08: format, this fix is resolving the format issue
Signed-off-by: Maor Dickman <[email protected]>
change the package to be iproute2 - this package install rmda
increase command and plugin timeout to support long operations in firmware
remove rdma - rdma is already fixed with the rigth package dependency
@filanov
Copy link
Collaborator Author

filanov commented Nov 24, 2024

replacing with #32

@filanov filanov closed this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.