-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional hbn related commands and log files. #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm just a couple of nits.
might be worth looking at udev rules to see if they are captured and if they have some logging that can be useful in terms of debugging.
yes, thats why I added /tmp/sf_devices and sfr_devices which are results of the udev processing and naming. |
sos/report/plugins/hbn.py
Outdated
plugin_name = "hbn" | ||
packages = ('hbn-repo',) | ||
packages = ('hbn-repo') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need a comma (,
) here because packages has to be a list :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Thanks @aserdean for the helpful reviews! |
Signed-off-by: Hareesh Puthalath <[email protected]>
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines