Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional hbn related commands and log files. #28

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

hareeshpc
Copy link


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • [ X] Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • [ X] Is the subject and message clear and concise?
  • [ X] Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • [ X] Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • [ X] Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • [X ] Are all passwords or private data gathered by this PR obfuscated?

sos/report/plugins/hbn.py Outdated Show resolved Hide resolved
sos/report/plugins/hbn.py Outdated Show resolved Hide resolved
sos/report/plugins/hbn.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@aserdean aserdean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just a couple of nits.

might be worth looking at udev rules to see if they are captured and if they have some logging that can be useful in terms of debugging.

sos/report/plugins/hbn.py Outdated Show resolved Hide resolved
sos/report/plugins/hbn.py Outdated Show resolved Hide resolved
sos/report/plugins/hbn.py Outdated Show resolved Hide resolved
sos/report/plugins/hbn.py Outdated Show resolved Hide resolved
sos/report/plugins/hbn.py Show resolved Hide resolved
sos/report/plugins/hbn.py Fixed Show resolved Hide resolved
sos/report/plugins/hbn.py Outdated Show resolved Hide resolved
@hareeshpc
Copy link
Author

hareeshpc commented Oct 30, 2024

lgtm just a couple of nits.

might be worth looking at udev rules to see if they are captured and if they have some logging that can be useful in terms of debugging.

yes, thats why I added /tmp/sf_devices and sfr_devices which are results of the udev processing and naming.

sos/report/plugins/hbn.py Outdated Show resolved Hide resolved
sos/report/plugins/hbn.py Outdated Show resolved Hide resolved
plugin_name = "hbn"
packages = ('hbn-repo',)
packages = ('hbn-repo')
Copy link
Collaborator

@aserdean aserdean Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a comma (,) here because packages has to be a list :(

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@hareeshpc
Copy link
Author

Thanks @aserdean for the helpful reviews!

@aserdean aserdean merged commit c026860 into NVIDIA:main Nov 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants