Fix CUDA 12.8 __nv_atomic_load_n call signature in SubbyteReference#3301
Open
wanghemeng wants to merge 1 commit into
Open
Fix CUDA 12.8 __nv_atomic_load_n call signature in SubbyteReference#3301wanghemeng wants to merge 1 commit into
wanghemeng wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a CUDA 12.8 compatibility issue in SubbyteReference.
Problem
Building CUTLASS with CUDA 12.8 fails with:
too few arguments in function call at subbyte_reference.h around __nv_atomic_load_n.Root cause
In CUDA 12.8, __nv_atomic_load_n requires a thread scope argument.
The existing code only passes memory order.
Fix
For CUDA >= 12.8, update:
_nv_atomic_load_n(ptr, __NV_ATOMIC_RELAXED)to:
_nv_atomic_load_n(ptr, __NV_ATOMIC_RELAXED, __NV_THREAD_SCOPE_DEVICE)Validation
Before fix: build failed in gemm_int4.cu.
After fix: build succeeds.