DistGEMM bug fixes #2713
Merged
DistGEMM bug fixes #2713
+84
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will try to check #2696 as well while this is open. |
alihassanijr
force-pushed
the
dist-gemm-blackwell-fixes
branch
from
aca3c0b to
acc7b79
Compare
alihassanijr
force-pushed
the
dist-gemm-blackwell-fixes
branch
from
e34ab96 to
08d37d3
Compare
|
Tested on GB200: B200 (DGX): H100 SXM (DGX): |
alihassanijr
force-pushed
the
dist-gemm-blackwell-fixes
branch
from
08d37d3 to
763f54c
Compare
|
Ready for review @hwu36 . |
1. If using preferred cluster, there needs to be a branch so that the universal GEMM wrapper finds the correct base params. 2. Workspace sizes can change depending on problem shape in Blackwell, and DistGEMM was previously using the per-device shape to evaluate workspace size instead of the per-gemm shape. 3. Flattened size used to initialize host tensors can overflow (in Hopper example as well) 4. Preferred and fallback cluster args need to be set explicitly, otherwise if someone modifies the example to use preferred cluster, it will just fail.
alihassanijr
force-pushed
the
dist-gemm-blackwell-fixes
branch
from
e5c5316 to
a932f25
Compare
hwu36
approved these changes
Nov 6, 2025
guocuimi
pushed a commit
to vectorch-ai/cutlass
that referenced
this pull request
Nov 6, 2025
* Blackwell DistGEMM bug fixes 1. If using preferred cluster, there needs to be a branch so that the universal GEMM wrapper finds the correct base params. 2. Workspace sizes can change depending on problem shape in Blackwell, and DistGEMM was previously using the per-device shape to evaluate workspace size instead of the per-gemm shape. 3. Flattened size used to initialize host tensors can overflow (in Hopper example as well) 4. Preferred and fallback cluster args need to be set explicitly, otherwise if someone modifies the example to use preferred cluster, it will just fail. * Fix example runtimes * Set default fallback cluster shapes to the static ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugs fixed: