fix: too early producer commit in examples/77_blackwell_fmha/kernel/sm100_fmha_mla_tma_warpspecialized.hpp #2502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The producer could commit when no copy is done.
|
@soundOfDestiny can you provide a list of steps to reproduce? I cannot reproduce the incorrect results on |
|
This PR has been labeled |
|
|
|
@soundOfDestiny I was looking into this issue, but I didn't see any correctness problems when I set StagesPV = 4. Do you have a configuration you tested that I can use to reproduce? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original code, the producer could commit when no copy is done.
We can observe incorrect results when setting
static const int StagesPV == 4;instead ofstatic const int StagesPV = StagesQK;, i.e. using a smallerStagesPVvalue.