-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Ensure compatibility with "-Wimplicit-fallthrough" when compiling with Clang #2324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Good point, though we should prefer a solution that doesn't use exceptions or |
This PR has been labeled |
@ccecka - What solution would suggest? Elsewhere in the project I see cutlass/tools/util/include/cutlass/util/device_rmsnorm.h Lines 181 to 182 in b995f93
and cutlass/examples/41_fused_multi_head_attention/fused_multi_head_attention_backward.cu Lines 89 to 90 in b995f93
and a number of uses of cutlass/tools/library/src/handle.cu Line 62 in b995f93
As contributors @wenxin0319 and I would like to match the existing project style, and it seems to us that If that's not the case, what should we do instead? |
keeping live. will get back to you |
We would prefer Approving now. |
@Junkai-Wu CC |
@hwu36 This PR is ready to merge. |
I've tried to enable |
This commit makes its files safe for use with "-Wimplicit-fallthrough".