Skip to content

Conversation

cwilkinson76
Copy link

@cwilkinson76 cwilkinson76 commented Oct 2, 2025

Description

Issue

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@cwilkinson76 cwilkinson76 requested a review from a team as a code owner October 2, 2025 21:39
Copy link

copy-pr-bot bot commented Oct 2, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change doc Improvements or additions to documentation labels Oct 2, 2025
@rgsl888prabhu
Copy link
Collaborator

/ok to test 8650b86

Copy link
Collaborator

@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cwilkinson76 for taking this one, I have requested few changes.

The ones I have asked to remove are CI related pushes and doesn't affect users.

@rgsl888prabhu
Copy link
Collaborator

@rg20 @chris-maes @tmckayus Please go through the README and please suggest any changes to Release notes

@rg20
Copy link
Contributor

rg20 commented Oct 3, 2025

Notes are missing barrier solve info, probably because its not merged yet.

@rgsl888prabhu
Copy link
Collaborator

Notes are missing barrier solve info, probably because its not merged yet.

Yes, this was created with latest update that was available when the PR was created. Please suggest changes to add any missing ones.

rgsl888prabhu and others added 4 commits October 3, 2025 11:00
Added barrier PR description and also made suggested review changes
@rgsl888prabhu
Copy link
Collaborator

@tmckayus @rg20 @chris-maes may I get your review on this PR ?

@rgsl888prabhu
Copy link
Collaborator

/ok to test 03be5ca

@rgsl888prabhu rgsl888prabhu requested review from a team as code owners October 6, 2025 20:37
@rgsl888prabhu
Copy link
Collaborator

/

@rgsl888prabhu
Copy link
Collaborator

/ok to test c3aae69

Copy link

copy-pr-bot bot commented Oct 6, 2025

/ok to test c3aae69

@rgsl888prabhu, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@rgsl888prabhu
Copy link
Collaborator

/ok to test c3aae6d

@rgsl888prabhu rgsl888prabhu added this to the 25.10 milestone Oct 6, 2025
@rgsl888prabhu rgsl888prabhu requested review from rg20 and tmckayus October 7, 2025 02:44
@rgsl888prabhu
Copy link
Collaborator

/ok to test c9ec238

@rgsl888prabhu
Copy link
Collaborator

/ok to test 0cb694a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants