[Tensornet backends] Make controlled rank a configurable setting #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For small controlled ops, i.e., singly controlled, expand the gate matrix and use cutensornetStateApplyTensorOperator. Add CUDAQ_TENSORNET_CONTROLLED_RANK threshold to determine when cutensornetStateApplyControlledTensorOperator is used. For MPS, this is fixed at 1 as it cannot handle gate ops with more than 2 qubits. Add doc for the setting and also remove some stale notes about random seeds in the docs. Signed-off-by: Thien Nguyen <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
| if (iter == m_gateDeviceMemCache.end()) { | ||
| void *dMem = allocateGateMatrix(task.matrix); | ||
| m_gateDeviceMemCache[gateKey] = dMem; | ||
| if (controls.size() <= m_maxControlledRankForFullTensorExpansion) { |
There was a problem hiding this comment.
Can we add a test to cover this scenario?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For small controlled ops, i.e., singly controlled, expand the gate matrix and use
cutensornetStateApplyTensorOperator.Add
CUDAQ_TENSORNET_CONTROLLED_RANKthreshold to determine whencutensornetStateApplyControlledTensorOperatorshould be used. For MPS, this is fixed at 1 as it cannot handle gate ops with more than 2 qubits.Add doc for the new setting and also remove some stale notes about random seeds (fixed in Support measurement sampling seed for
cutensornetbackends #2398) in the docs.