[python] Remove unused MLIR components #2443
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boschmitt
force-pushed
the
shrink_nvqpp_python
branch
4 times, most recently
from
e8b6526 to
a8cef3f
Compare
We don't need to take everything from MLIR for our python bindings. This change cherry picks the upstream components our compiler depends on. The commit also cleans up some unnecessary code that ends up registering dialects more than once, and surfaces the `register_all_dialects` function to a less obscure location. Signed-off-by: boschmitt <[email protected]>
boschmitt
force-pushed
the
shrink_nvqpp_python
branch
from
a8cef3f to
5b4059b
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
reviewed
Dec 13, 2024
|
|
||
| void registerQuakeDialectAndTypes(py::module &m) { | ||
| void registerQuakeTypes(py::module &m) { |
There was a problem hiding this comment.
Suggested change
| void registerQuakeTypes(py::module &m) { | |
| static void registerQuakeTypes(py::module &m) { |
| @@ -143,21 +115,10 @@ void registerQuakeDialectAndTypes(py::module &m) { | |||
| }); | |||
| } | |||
|
|
|||
| void registerCCDialectAndTypes(py::module &m) { | |||
| void registerCCTypes(py::module &m) { | |||
There was a problem hiding this comment.
Suggested change
| void registerCCTypes(py::module &m) { | |
| static void registerCCTypes(py::module &m) { |
Assuming that's ok, should move these 2 out of the namespace as well.
| registerAllDialects(registry); | ||
| auto *mlirContext = unwrap(context); | ||
| cudaq::registerAllDialects(registry); | ||
| MLIRContext *mlirContext = unwrap(context); | ||
| mlirContext->appendDialectRegistry(registry); | ||
| mlirContext->loadAllAvailableDialects(); |
There was a problem hiding this comment.
Does loadAllAvailableDialects actually load Quake, CC, and CodeGen?
Do we need an explicit test to verify that all the dialects we expect to be loaded are loaded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don't need to take everything from MLIR for our python bindings. This change cherry picks the upstream components our compiler depends on.
The commit also cleans up some unnecessary code that ends up registering dialects more than once, and surfaces the
register_all_dialectsfunction to a less obscure location.EDIT: The process of registering dialects can be further improved and made completely automatic. MLIR provides a global
_dialect_registrythat gets automatically populated with all upstream dialects whenRegisterEverythingis built. This global registry is loaded to allContext()objects on its__init__method. We can populate this global registry whenevercudaq.mliris loaded so that everyContext()gets all dialects that we need. This improvement will be left for later work.