Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] Fix double installation of nvq++ libs. #2441

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

boschmitt
Copy link
Collaborator

Description

This PR disables MLIR's installation of our optimizer's libs. We do it ourselves. Fixing this problem is particularly relevant our python wheels: The issue is aggravated there because the manylinux image has an enviroment that favors libraries to be installed in lib64 prefix. MLIR's build system honors that; our's don't, and thus we ship wheels that have these libs installed twice, one in lib and another in lib64.

The issue that these libs don't need to be part of the wheels will be addressed in a later commit.

This PR disables MLIR's installation of our optimizer's libs. We do it
ourselves. Fixing this problem is particularly relevant our python
wheels: The issue is aggravated there because the manylinux image has an
enviroment that favors libraries to be installed in `lib64` prefix.
MLIR's build system honors that; our's don't, and thus we ship wheels
that have these libs installed twice, one in `lib` and another in
`lib64`.

The issue that these libs don't need to be part of the wheels will be
addressed in a later commit.

Signed-off-by: boschmitt <[email protected]>
@schweitzpgi schweitzpgi added the build The issue related to the CUDA Quantum build label Dec 10, 2024
@schweitzpgi
Copy link
Collaborator

Do these have to be installed in lib/? It sounds like we're not installing them to the correct directory from the description.

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The issue related to the CUDA Quantum build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants