-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ElementaryOpoerator.define override option #2419
Open
ikkoham
wants to merge
7
commits into
NVIDIA:main
Choose a base branch
from
ikkoham:feature/ElementaryOperator-redefine
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I, ikkoham <[email protected]>, hereby add my Signed-off-by to this commit: ef0c599 Signed-off-by: ikkoham <[email protected]>
schweitzpgi
added
the
python-lang
Anything related to the Python CUDA Quantum language implementation
label
Dec 10, 2024
bettinaheim
approved these changes
Dec 11, 2024
Command Bot: Processing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are cases where we want to experiment with various definitions of the Hamiltonian and collapse operators.
Of course, it's possible to modify the
id
during execution or exploit lazy evaluation (I will mention this later), but these approaches don’t feel intuitive.Therefore, I'd like to propose an option to allow overrides. By using this, users will be able to conduct experiments with different definitions more intuitively and effectively. Especially when developing with Jupyter Notebook, it’s quite inconvenient to have to restart the kernel every time we want to change a definition.
This proposal allows
Alternatives (Workaround)
Use different id.
Redefine the operator itself. (lazy evaluation)