Fix passing lists of boolean values to kernels in python. #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I, Anna Gringauze <[email protected]>, hereby add my Signed-off-by to this commit: 69ff3bd Signed-off-by: Anna Gringauze <[email protected]>
schweitzpgi
reviewed
Nov 19, 2024
| @@ -393,11 +393,11 @@ inline void packArgs(OpaqueArguments &argData, py::args args, | |||
| .Case([&](IntegerType type) { | |||
| // Handle vec<bool> and vec<int> | |||
| if (type.getIntOrFloatBitWidth() == 1) { | |||
| genericVecAllocator.template operator()<bool>( | |||
| genericVecAllocator.template operator()<char>( | |||
There was a problem hiding this comment.
Is this required if we merge #2338 ?
There was a problem hiding this comment.
The changes to this file can be dropped AFAICT.
It would be great to add the extended tests though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix passing lists of boolean values to kernels in python.
Closes: #2262
Closes: #2330