-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the options data class to program #237
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some drive-by observations. Feel free to ignore!
Thanks, Berry 🙏 We welcome feedbacks and won't ignore anyone! |
Another TODO: Let's also update the code samples and show the best practice! |
Is there a way to add these as doctests so that the code samples must always be kept in working order? |
@warsawnv Totally. I'm actively working on getting github actions working, and the examples are invoked as part of the testsuite. |
/ok to test |
Very good point |
03128c8
to
6d789cb
Compare
/ok to test |
/ok to test |
close #221
Add the options class to Program.
TODO modify the test so that it compiles the program with options once the CI is in place. I was running into compile issues that seemed related to my environment.