Skip to content

[no-ci] fix(ci): pr-metadata-check — blocked-label bug, exact match, multi-word labels #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rwgk merged 5 commits into from
Mar 31, 2026
Merged

[no-ci] fix(ci): pr-metadata-check — blocked-label bug, exact match, multi-word labels #1836

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
71be2c2
Fix blocked-label check falsely matching "documentation"
rwgk Mar 31, 2026
c6b46b5
Apply reviewer suggestion: Match blocked labels exactly (case-insensi…
rwgk Mar 31, 2026
1cb9360
fix(ci): iterate PR labels line-wise for module/type checks
rwgk Mar 31, 2026
fb8f52d
fix(ci): show GitHub casing for blocked-label errors
rwgk Mar 31, 2026
5f0bb68
Merge branch 'main' into pr-metadata-check-fixes
rwgk Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions .github/workflows/pr-metadata-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,14 @@ jobs:
fi

# Block PRs with labels that indicate they are not ready to merge.
BLOCKED_PATTERNS="blocked DO NOT MERGE do not merge"
for label in $LABEL_NAMES; do
for pattern in $BLOCKED_PATTERNS; do
if echo "$label" | grep -qi "$pattern"; then
ERRORS="${ERRORS}- **Blocked label detected**: label \`$label\` prevents merging. Remove it when the PR is ready.\n"
break
fi
done
done
# Read labels line-by-line (jq outputs one per line) to handle
# multi-word label names; match with a single regex to avoid
# word-splitting "DO NOT MERGE" into individual grep patterns.
while IFS= read -r label; do
if echo "$label" | grep -qiE "blocked|do not merge"; then
ERRORS="${ERRORS}- **Blocked label detected**: label \`$label\` prevents merging. Remove it when the PR is ready.\n"
fi
done < <(echo "$LABELS" | jq -r '.[].name')
Comment thread
rwgk marked this conversation as resolved.
Outdated

if [ -n "$ERRORS" ]; then
echo "::error::This PR is missing required metadata. See the job summary for details."
Expand Down
Loading