Skip to content

Ensure allocation stream is used for buffer deallocation if no explicit stream is provided #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Ensure allocation stream is used for buffer deallocation if no explicit stream is provided #1032

wants to merge 18 commits into from

Conversation

leofang
Copy link
Member

@leofang leofang commented Sep 26, 2025

Description

closes #779.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Sep 26, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang self-assigned this Sep 26, 2025
@leofang leofang added P0 High priority - Must do! cuda.core Everything related to the cuda.core module breaking Breaking changes are introduced labels Sep 26, 2025
@leofang leofang added this to the cuda.core beta 7 milestone Sep 26, 2025
@leofang
Copy link
Member Author

leofang commented Sep 26, 2025

/ok to test 738eed4

@github-actions GitHub Actions
Copy link

Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-1032/

https://nvidia.github.io/cuda-python/pr-preview/pr-1032/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-1032/cuda-bindings/

https://nvidia.github.io/cuda-python/pr-preview/pr-1032/cuda-pathfinder/


Preview will be ready when the GitHub Pages deployment is complete.

cpcloud
cpcloud reviewed Sep 30, 2025
View reviewed changes
cpcloud
cpcloud reviewed Sep 30, 2025
View reviewed changes
leofang added 17 commits October 3, 2025 03:34
@leofang leofang added the blocked This task is currently blocked by other tasks label Oct 5, 2025
@leofang
Copy link
Member Author

leofang commented Oct 5, 2025

(This PR is now based entirely on #1070 except for the last commit, so that PR needs to be merged first.)

@leofang
Copy link
Member Author

leofang commented Oct 5, 2025

/ok to test 605241e

@leofang leofang requested a review from shwina October 6, 2025 13:13
kkraus14
kkraus14 reviewed Oct 6, 2025
View reviewed changes
Copy link
Collaborator

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way we could add some testing for stream ordered allocations / deallocations?

@leofang leofang mentioned this pull request Oct 6, 2025
Open
2 tasks
@rwgk rwgk mentioned this pull request Oct 6, 2025
Merged
@kkraus14
Copy link
Collaborator

kkraus14 commented Oct 7, 2025

Changes LGTM on top of #1070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud left review comments

@rparolin rparolin rparolin left review comments

@kkraus14 kkraus14 kkraus14 left review comments

@shwina shwina Awaiting requested review from shwina

At least 1 approving review is required to merge this pull request.

Assignees

@leofang leofang

Labels
blocked This task is currently blocked by other tasks breaking Breaking changes are introduced cuda.core Everything related to the cuda.core module P0 High priority - Must do!
Projects
None yet
Milestone
cuda.core beta 7
Development

Successfully merging this pull request may close these issues.

Buffer deallocation always happens on default stream
4 participants
@leofang @kkraus14 @cpcloud @rparolin