Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to installing Doxygen via conda #636

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Switch to installing Doxygen via conda #636

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
87a9834
test
PointKernel Nov 6, 2024
0499cd0
Add env file
PointKernel Nov 6, 2024
e8463d2
Check doxygen version
PointKernel Nov 7, 2024
e1bd1bc
Revert pre-commit config
PointKernel Nov 7, 2024
2b1fa5a
Update
PointKernel Nov 7, 2024
424cc22
Merge remote-tracking branch 'upstream/dev' into fix-doxygen-ci
PointKernel Nov 13, 2024
731b7c7
Use conda to install doxygen
PointKernel Nov 13, 2024
e93e251
Add conda-forge channel
PointKernel Nov 13, 2024
8f55200
Test
PointKernel Nov 13, 2024
9081144
test
PointKernel Nov 13, 2024
e126f42
Remove unused file
PointKernel Nov 13, 2024
17f5626
Revert test changes
PointKernel Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,13 @@ jobs:
steps:
- name: Checkout repo
uses: actions/checkout@v3
- name: Install Doxygen
run: |
sudo apt-get update -q
sudo apt-get install -y doxygen
- name: Check Doxygen docs
- name: Install and Check Doxygen
run: |
conda init bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s move all of this to a standalone bash script.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model it after https://github.com/rapidsai/cudf/blob/branch-24.12/ci/check_style.sh.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need conda after all? We could just wget one of the binary releases from the doxygen GH repo. I'm not saying I'm against conda, I'm just wondering if it comes with any additional overhead compared to downloading the raw binary and placing it in an executable path.

source /usr/share/miniconda/etc/profile.d/conda.sh
conda create -n doxygen_env -c conda-forge doxygen=1.9.1 -y
conda activate doxygen_env
doxygen --version
./ci/pre-commit/doxygen.sh
if [ $? -ne 0 ]; then
echo "Doxygen check failed"
Expand Down Expand Up @@ -102,4 +103,4 @@ jobs:
|| contains(needs.*.result, 'cancelled')
|| contains(needs.*.result, 'skipped')
}}
run: exit 1
run: exit 1
Loading