Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add experimental multimap insert and contains #549

Merged
merged 5 commits into from
Jul 21, 2024
Merged

Add experimental multimap insert and contains #549

merged 5 commits into from
Jul 21, 2024

Conversation

PointKernel
Copy link
Member

This PR adds a new experimental::static_multimap using the new OA design. It adds insert and contains operations for the new multimap.

@PointKernel PointKernel added Needs Review Awaiting reviews before merging topic: static_multimap Issue related to the static_multimap type: improvement Improvement / enhancement to an existing function labels Jul 16, 2024
@PointKernel PointKernel requested a review from sleeepyjack as a code owner July 16, 2024 21:38
sleeepyjack
sleeepyjack reviewed Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@sleeepyjack sleeepyjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round.

Looks great!

It's very pleasant to see that with all of our previous refactoring work, implementing the new static_multimap boils down simply dispatching from the frontend API to the OA backend API ❤️

include/cuco/detail/static_multimap/static_multimap.inl Show resolved Hide resolved
include/cuco/static_multimap.cuh Outdated Show resolved Hide resolved
@PointKernel PointKernel requested a review from sleeepyjack July 19, 2024 17:06
sleeepyjack
sleeepyjack reviewed Jul 19, 2024
View reviewed changes
include/cuco/detail/static_multimap/static_multimap.inl Outdated Show resolved Hide resolved
include/cuco/detail/static_multimap/static_multimap_ref.inl Outdated Show resolved Hide resolved
include/cuco/detail/static_multimap/static_multimap_ref.inl Outdated Show resolved Hide resolved
include/cuco/detail/static_multimap/static_multimap_ref.inl Outdated Show resolved Hide resolved
include/cuco/detail/static_multimap/static_multimap_ref.inl Outdated Show resolved Hide resolved
include/cuco/detail/static_multimap/static_multimap_ref.inl Outdated Show resolved Hide resolved
include/cuco/detail/static_multimap/static_multimap_ref.inl Outdated Show resolved Hide resolved
include/cuco/detail/static_multimap/static_multimap_ref.inl Outdated Show resolved Hide resolved
include/cuco/detail/static_multimap/static_multimap_ref.inl Outdated Show resolved Hide resolved
include/cuco/static_multimap_ref.cuh Show resolved Hide resolved
sleeepyjack
sleeepyjack approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@sleeepyjack sleeepyjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few minor thinsg this PR is good to go. I'm gonna approve it now so we can merge it ASAP.

@PointKernel PointKernel mentioned this pull request Jul 21, 2024
Open
@PointKernel PointKernel merged commit c05af72 into NVIDIA:dev Jul 21, 2024
15 checks passed
@PointKernel PointKernel deleted the experimental-multimap branch July 21, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleeepyjack sleeepyjack sleeepyjack approved these changes

Assignees
No one assigned
Labels
Needs Review Awaiting reviews before merging topic: static_multimap Issue related to the static_multimap type: improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
Refactor Open Address Data Structures
Development

Successfully merging this pull request may close these issues.
2 participants
@PointKernel @sleeepyjack