-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit test for scalar vs. CGSize1 probing #509
Conversation
Found the culprit with |
With #501 fixing the sanitize hash logic, removing |
that fix broke something else: https://github.com/NVIDIA/cuCollections/actions/runs/9584556889/job/26440581801?pr=509#step:7:758 |
Which fix are you referring to? removing |
Operator presedence: f0ae693 Not sure where my logic is flawed. 😢 |
No good way but printing out all probing steps. I will take a look tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ready to go.
You sir are the MVP |
This PR adds a unit test to verify that the probing sequences for the scalar probing iterator vs. the iterator that uses a cooperative group of size 1 are actually equivalent.