Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic_bitset #352

Merged
merged 104 commits into from
Sep 8, 2023
Merged

Add dynamic_bitset #352

merged 104 commits into from
Sep 8, 2023

Conversation

amukkara
Copy link
Contributor

@amukkara amukkara commented Aug 17, 2023

This PR adds dynamic_bitset code that will be used in Trie data structure. Trie will be integrated in a separate PR #350.

Since dynamic_bitset is not intended to be part of public-facing API, all files (.cuh and .inl) are located in include/cuco/detail/trie/dynamic_bitset

Tests are added in tests/dynamic_bitset

@rapids-bot
Copy link

rapids-bot bot commented Aug 17, 2023

Pull requests from external contributors require approval from a NVIDIA organization member with write permissions or greater before CI can begin.

@GPUtester
Copy link

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@PointKernel PointKernel added the Needs Review Awaiting reviews before merging label Aug 17, 2023
 rank,   select  ->  rank_true,  select_true

 rank0, select0  ->  rank_false, select_false
include/cuco/detail/trie/dynamic_bitset/dynamic_bitset.cuh Outdated Show resolved Hide resolved
include/cuco/detail/trie/dynamic_bitset/dynamic_bitset.cuh Outdated Show resolved Hide resolved
include/cuco/detail/trie/dynamic_bitset/dynamic_bitset.cuh Outdated Show resolved Hide resolved
include/cuco/detail/trie/dynamic_bitset/dynamic_bitset.cuh Outdated Show resolved Hide resolved
include/cuco/detail/trie/dynamic_bitset/dynamic_bitset.cuh Outdated Show resolved Hide resolved
include/cuco/detail/trie/dynamic_bitset/dynamic_bitset.cuh Outdated Show resolved Hide resolved
include/cuco/detail/trie/dynamic_bitset/dynamic_bitset.cuh Outdated Show resolved Hide resolved
include/cuco/detail/trie/dynamic_bitset/kernels.cuh Outdated Show resolved Hide resolved
include/cuco/detail/trie/dynamic_bitset/kernels.cuh Outdated Show resolved Hide resolved
@PointKernel
Copy link
Member

/ok to test

@PointKernel
Copy link
Member

/ok to test

Copy link
Collaborator

@sleeepyjack sleeepyjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PointKernel PointKernel merged commit 641c868 into NVIDIA:dev Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting reviews before merging type: feature request New feature request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants