Draft
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
😬 CI Workflow Results🟥 Finished in 1h 46m: Pass: 16%/249 | Total: 7d 07h | Max: 1h 45m | Hits: 72%/61152See results here. |
miscco
reviewed
Mar 30, 2026
| CompileTimeArray<OutputT, 0, ITEMS_PER_THREAD> arr{input_items, output_items}; | ||
| arr.Transpose(lane_id, member_mask); | ||
| InputT vals[ITEMS_PER_THREAD]; | ||
| for (int i = 0; i < ITEMS_PER_THREAD; i++) |
Contributor
There was a problem hiding this comment.
We are commonly adding
Suggested change
| for (int i = 0; i < ITEMS_PER_THREAD; i++) | |
| _CCCL_PRAGMA_UNROLL_FULL() | |
| for (int i = 0; i < ITEMS_PER_THREAD; i++) |
|
|
||
| transpose<ITEMS_PER_THREAD / 2>(lane_id, member_mask); | ||
|
|
||
| for (int i = 0; i < ITEMS_PER_THREAD; i++) |
Contributor
There was a problem hiding this comment.
Suggested change
| for (int i = 0; i < ITEMS_PER_THREAD; i++) | |
| _CCCL_PRAGMA_UNROLL_FULL() | |
| for (int i = 0; i < ITEMS_PER_THREAD; i++) |
| , val{input_items[IDX]} | ||
| {} | ||
| constexpr int next_idx = IDX + 1 + ((IDX + 1) % NUM_ENTRIES == 0) * NUM_ENTRIES; | ||
| transpose_foreach<next_idx, NUM_ENTRIES>(vals, xor_bit_set, mask); |
Contributor
There was a problem hiding this comment.
Maybe I am stupid, but how does this function terminate?
Contributor
Author
There was a problem hiding this comment.
No, you are not. I indeed missed the termination condition. Thx!
bernhardmgruber
force-pushed
the
ref_WarpExchangeShfl
branch
from
c2d8f36 to
1166cff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.