-
Notifications
You must be signed in to change notification settings - Fork 283
Dropped duplicated math function from Thrust #6188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove
#include <thrust/detail/integer_math.h>
from files where we no longer need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on this issue. It is already looking great.
I found one incorrect replacement and some potential conversion issues
@bernhardmgruber @miscco all changes that you guys suggested is done, lmk if there are more Changes. :) |
@viralbhadeshiya This looks great 🎉 Thanks a lot for working on this. I added a few minor changes:
|
/ok to test 07b811c |
/ok to test 8f713c8 |
This comment has been minimized.
This comment has been minimized.
Seems like couple of jobs are failing, @miscco lmk if it requires any changes for it, happy to do it. |
/ok to test b90a202 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could also consider to move is_negative
to libcu++ as an internal function
This comment has been minimized.
This comment has been minimized.
/ok to test 4261f1f |
😬 CI Workflow Results🟥 Finished in 4h 52m: Pass: 93%/118 | Total: 7d 09h | Max: 4h 51m | Hits: 42%/165484See results here. |
Description
closes #6104
Checklist