Skip to content

Conversation

viralbhadeshiya
Copy link

@viralbhadeshiya viralbhadeshiya commented Oct 10, 2025

Description

closes #6104

  • Removed duplicated math function from Thrust
  • Moved all duplicated math function call from Thrust to cuda/std or cuda

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link
Contributor

copy-pr-bot bot commented Oct 10, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-project-automation github-project-automation bot moved this to Todo in CCCL Oct 10, 2025
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Oct 10, 2025
Copy link
Contributor

@bernhardmgruber bernhardmgruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

#include <thrust/detail/integer_math.h>

from files where we no longer need it.

Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this issue. It is already looking great.

I found one incorrect replacement and some potential conversion issues

@github-project-automation github-project-automation bot moved this from In Review to In Progress in CCCL Oct 11, 2025
@viralbhadeshiya
Copy link
Author

@bernhardmgruber @miscco all changes that you guys suggested is done, lmk if there are more Changes. :)

@miscco
Copy link
Contributor

miscco commented Oct 13, 2025

@viralbhadeshiya This looks great 🎉

Thanks a lot for working on this.

I added a few minor changes:

  • dropped unused is_odd
  • improved is_negative
  • dropped two more includes

@miscco
Copy link
Contributor

miscco commented Oct 13, 2025

/ok to test 07b811c

@miscco
Copy link
Contributor

miscco commented Oct 13, 2025

/ok to test 8f713c8

This comment has been minimized.

@viralbhadeshiya
Copy link
Author

Seems like couple of jobs are failing, @miscco lmk if it requires any changes for it, happy to do it.

@bernhardmgruber
Copy link
Contributor

/ok to test b90a202

Copy link
Contributor

@fbusato fbusato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also consider to move is_negative to libcu++ as an internal function

This comment has been minimized.

@github-project-automation github-project-automation bot moved this from In Progress to In Review in CCCL Oct 15, 2025
@miscco
Copy link
Contributor

miscco commented Oct 15, 2025

/ok to test 4261f1f

Copy link
Contributor

😬 CI Workflow Results

🟥 Finished in 4h 52m: Pass: 93%/118 | Total: 7d 09h | Max: 4h 51m | Hits: 42%/165484

See results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

[FEA]: Drop duplicated math functions from Thrust

4 participants