Skip to content

Conversation

tpn
Copy link
Contributor

@tpn tpn commented Oct 8, 2025

This looks ready for a more thorough review now, all tests are passing. This PR supersedes the WIP PR that was created pre compute/coop rename. I figured it was easier to create a new branch and squash all those commits to make the rebase from main easier.

Copy link
Contributor

copy-pr-bot bot commented Oct 8, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Progress in CCCL Oct 8, 2025
@tpn
Copy link
Contributor Author

tpn commented Oct 8, 2025

/ok to test 288ee4c

This comment has been minimized.

@tpn tpn force-pushed the 5289-windows-ci-python-cuda-cccl-support-v2 branch from 288ee4c to a5b63f5 Compare October 9, 2025 16:59
@tpn
Copy link
Contributor Author

tpn commented Oct 9, 2025

/ok to test a5b63f5

@tpn tpn force-pushed the 5289-windows-ci-python-cuda-cccl-support-v2 branch from a5b63f5 to 6c8a2f2 Compare October 9, 2025 18:02

This comment has been minimized.

@tpn
Copy link
Contributor Author

tpn commented Oct 9, 2025

/ok to test 6c8a2f2

@tpn tpn marked this pull request as ready for review October 9, 2025 19:00
@tpn tpn requested review from a team as code owners October 9, 2025 19:00
@tpn tpn requested review from elstehle and shwina October 9, 2025 19:00
@cccl-authenticator-app cccl-authenticator-app bot moved this from In Progress to In Review in CCCL Oct 9, 2025
@tpn tpn changed the title [WIP] Implement initial Windows CI support for the Python cuda-cccl library. Implement initial Windows CI support for the Python cuda-cccl library. Oct 9, 2025
@tpn tpn requested review from alliepiper and wmaxey October 9, 2025 19:02

This comment has been minimized.

Copy link
Contributor

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did an initial review of the infra side of things, left a couple notes.

Run a test with an override matrix of

  - {jobs: ['test'], project: 'python', ctk: ['12.0', '12.X', '13.0', '13.X'], cxx: ['msvc'], py_version: ['3.10', '3.11', '3.12', '3.13'], gpu: 'l4'}

to make sure that this works on the same matrix as the linux wheels. We'll need to add coverage to the pr/nightly/weekly workflows once that's working.

This comment has been minimized.

@tpn tpn force-pushed the 5289-windows-ci-python-cuda-cccl-support-v2 branch from 7ed6cc5 to f18f99e Compare October 10, 2025 00:49

This comment has been minimized.

This comment has been minimized.

@tpn tpn force-pushed the 5289-windows-ci-python-cuda-cccl-support-v2 branch 2 times, most recently from da8b8fd to ba7f01e Compare October 13, 2025 18:34

This comment has been minimized.

@tpn tpn force-pushed the 5289-windows-ci-python-cuda-cccl-support-v2 branch 4 times, most recently from 2796b62 to 42b2754 Compare October 13, 2025 23:01

This comment has been minimized.

@tpn tpn force-pushed the 5289-windows-ci-python-cuda-cccl-support-v2 branch 2 times, most recently from 88928c1 to 1a1822b Compare October 14, 2025 03:40

This comment has been minimized.

@tpn tpn force-pushed the 5289-windows-ci-python-cuda-cccl-support-v2 branch from 1a1822b to e6e2a74 Compare October 14, 2025 14:13
@tpn tpn requested a review from cryos October 14, 2025 14:53
@tpn tpn self-assigned this Oct 14, 2025
Copy link
Contributor

@cryos cryos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything outside of the powershell looks good to me, there is a lot of new powershell and I am not overly familiar with it, so I would defer to others there.

This comment has been minimized.

@tpn tpn force-pushed the 5289-windows-ci-python-cuda-cccl-support-v2 branch from cb35722 to e9ef150 Compare October 15, 2025 00:02
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way CCCL uses docker can only get more insane, not less! 😂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I mentioned in the meeting, but one thing we could do is to install Git Bash in the CI so as to reuse the same bash scripts on Windows. (ps. I did not review the powershell scripts either 😛)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have git bash installed -- this is something I'd like to move towards (and have started with the artifact/workflow util scripts), but would be difficult with the current python docker build requirements.

This comment has been minimized.

This comment has been minimized.

@alliepiper alliepiper force-pushed the 5289-windows-ci-python-cuda-cccl-support-v2 branch from fde3df2 to 43202da Compare October 15, 2025 18:35
Copy link
Contributor

🥳 CI Workflow Results

🟩 Finished in 1h 49m: Pass: 100%/60 | Total: 1d 01h | Max: 47m 12s

See results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

5 participants