-
Notifications
You must be signed in to change notification settings - Fork 283
Implement initial Windows CI support for the Python cuda-cccl library. #6160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test 288ee4c |
This comment has been minimized.
This comment has been minimized.
288ee4c
to
a5b63f5
Compare
/ok to test a5b63f5 |
a5b63f5
to
6c8a2f2
Compare
This comment has been minimized.
This comment has been minimized.
/ok to test 6c8a2f2 |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did an initial review of the infra side of things, left a couple notes.
Run a test with an override matrix of
- {jobs: ['test'], project: 'python', ctk: ['12.0', '12.X', '13.0', '13.X'], cxx: ['msvc'], py_version: ['3.10', '3.11', '3.12', '3.13'], gpu: 'l4'}
to make sure that this works on the same matrix as the linux wheels. We'll need to add coverage to the pr/nightly/weekly workflows once that's working.
This comment has been minimized.
This comment has been minimized.
7ed6cc5
to
f18f99e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
da8b8fd
to
ba7f01e
Compare
This comment has been minimized.
This comment has been minimized.
2796b62
to
42b2754
Compare
This comment has been minimized.
This comment has been minimized.
88928c1
to
1a1822b
Compare
This comment has been minimized.
This comment has been minimized.
1a1822b
to
e6e2a74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything outside of the powershell looks good to me, there is a lot of new powershell and I am not overly familiar with it, so I would defer to others there.
This comment has been minimized.
This comment has been minimized.
cb35722
to
e9ef150
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way CCCL uses docker can only get more insane, not less! 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I mentioned in the meeting, but one thing we could do is to install Git Bash in the CI so as to reuse the same bash scripts on Windows. (ps. I did not review the powershell scripts either 😛)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have git bash installed -- this is something I'd like to move towards (and have started with the artifact/workflow util scripts), but would be difficult with the current python docker build requirements.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fde3df2
to
43202da
Compare
🥳 CI Workflow Results🟩 Finished in 1h 49m: Pass: 100%/60 | Total: 1d 01h | Max: 47m 12sSee results here. |
This looks ready for a more thorough review now, all tests are passing. This PR supersedes the WIP PR that was created pre compute/coop rename. I figured it was easier to create a new branch and squash all those commits to make the rebase from main easier.