added slow test label and execute full testing suite before merge #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorotat-nv
added
INCLUDE_NOTEBOOKS_TESTS
dorotat-nv
requested review from
jstjohn,
pstjohn and
trvachov
as code owners
jstjohn
reviewed
Jan 22, 2025
jstjohn
approved these changes
Jan 22, 2025
pstjohn
reviewed
Jan 22, 2025
pstjohn
reviewed
Jan 22, 2025
pstjohn
reviewed
Jan 22, 2025
pstjohn
approved these changes
Jan 22, 2025
dorotat-nv
added
the
INCLUDE_SLOW_TESTS
pstjohn
approved these changes
Jan 23, 2025
Signed-off-by: Peter St. John <[email protected]>
pstjohn
requested review from
skothenhill-nv,
jomitchellnv,
farhadrgh and
sichu2023
as code owners
dorotat-nv
removed
INCLUDE_NOTEBOOKS_TESTS
|
tests are failing due to being broken on main |
dorotat-nv
added
the
INCLUDE_NOTEBOOKS_TESTS
Signed-off-by: Dorota Toczydlowska <[email protected]>
Signed-off-by: Dorota Toczydlowska <[email protected]>
dorotat-nv
commented
Jan 23, 2025
dorotat-nv
changed the title
pstjohn
added a commit
that referenced
this pull request
Jan 23, 2025
This is one remaining outlier in our current test suite that takes a long time to run (~3 minutes by itself). https://app.codecov.io/gh/NVIDIA/bionemo-framework/tests/main With #634 we'll run these tests anyways during the merge queue step, but marking this as slow should speed up the coverage runs in PRs and post-merge Signed-off-by: Peter St. John <[email protected]>
pstjohn
added a commit
that referenced
this pull request
Jan 23, 2025
This is one remaining outlier in our current test suite that takes a long time to run (~3 minutes by itself). https://app.codecov.io/gh/NVIDIA/bionemo-framework/tests/main With #634 we'll run these tests anyways during the merge queue step, but marking this as slow should speed up the coverage runs in PRs and post-merge Signed-off-by: Peter St. John <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 118 118
Lines 7058 7058
=======================================
Hits 6123 6123
Misses 935 935 ☔ View full report in Codecov by Sentry. |
auto-merge was automatically disabled
January 23, 2025 22:45
Pull Request is not mergeable
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
This is one remaining outlier in our current test suite that takes a long time to run (~3 minutes by itself). https://app.codecov.io/gh/NVIDIA/bionemo-framework/tests/main With #634 we'll run these tests anyways during the merge queue step, but marking this as slow should speed up the coverage runs in PRs and post-merge --------- Signed-off-by: Peter St. John <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
polinabinder1
pushed a commit
that referenced
this pull request
Jan 28, 2025
This is one remaining outlier in our current test suite that takes a long time to run (~3 minutes by itself). https://app.codecov.io/gh/NVIDIA/bionemo-framework/tests/main With #634 we'll run these tests anyways during the merge queue step, but marking this as slow should speed up the coverage runs in PRs and post-merge --------- Signed-off-by: Peter St. John <[email protected]> Signed-off-by: Polina Binder <[email protected]>
polinabinder1
pushed a commit
that referenced
this pull request
Jan 28, 2025
### Description Adding INCLUDE_SLOW_TESTS label which runs tests of slower execution as well as enforcing full scope testing in CI pipelines for merge_queue event Updated documentation ### Type of changes <!-- Mark the relevant option with an [x] --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Refactor - [ ] Documentation update - [ ] Other (please describe): ### CI Pipeline Configuration Configure CI behavior by applying the relevant labels: - [SKIP_CI](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#skip_ci) - Skip all continuous integration tests - [INCLUDE_NOTEBOOKS_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_notebooks_tests) - Execute notebook validation tests in pytest > [!NOTE] > By default, the notebooks validation tests are skipped unless explicitly enabled. ### Usage <!--- How does a user interact with the changed code --> ```python TODO: Add code snippet ``` ### Pre-submit Checklist <!--- Ensure all items are completed before submitting --> - [ ] I have tested these changes locally - [ ] I have updated the documentation accordingly - [ ] I have added/updated tests as needed - [ ] All existing tests pass successfully --------- Signed-off-by: Peter St. John <[email protected]> Signed-off-by: Dorota Toczydlowska <[email protected]> Co-authored-by: Peter St. John <[email protected]> Signed-off-by: Polina Binder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding INCLUDE_SLOW_TESTS label which runs tests of slower execution as well as enforcing full scope testing in CI pipelines for merge_queue event
Updated documentation
Type of changes
CI Pipeline Configuration
Configure CI behavior by applying the relevant labels:
Note
By default, the notebooks validation tests are skipped unless explicitly enabled.
Usage
Pre-submit Checklist