Implement megatron-aware perplexity in torchmetrics #525
+168
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sichu2023
force-pushed
the
sichu/update-ddp-config
branch
2 times, most recently
from
ecd102a to
cfa66d3
Compare
pstjohn
reviewed
Dec 12, 2024
sichu2023
force-pushed
the
sichu/update-ddp-config
branch
from
cfa66d3 to
e1e9037
Compare
jstjohn
reviewed
Dec 16, 2024
sub-packages/bionemo-esm2/src/bionemo/esm2/scripts/train_esm2.py
Outdated
Show resolved
Hide resolved
jstjohn
reviewed
Dec 16, 2024
sub-packages/bionemo-esm2/src/bionemo/esm2/scripts/train_esm2.py
Outdated
Show resolved
Hide resolved
jstjohn
reviewed
Dec 16, 2024
|
|
sichu2023
force-pushed
the
sichu/torchmetrics-ppl-logging
branch
from
2fd1fd7 to
4959e80
Compare
sichu2023
requested review from
farhadrgh,
dorotat-nv,
malcolmgreaves and
skothenhill-nv
as code owners
sichu2023
force-pushed
the
sichu/torchmetrics-ppl-logging
branch
from
1de355d to
32e0568
Compare
|
On multi-device DP |
|
And on multi-device TP x DP. |
sichu2023
force-pushed
the
sichu/torchmetrics-ppl-logging
branch
from
007c6e0 to
78aa7a3
Compare
|
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace
PerplexityLoggingCallbackwith parallelism-awareMegatronPerplexityMetric. Pipeline parallel is not supported yet.Usage
Added perplexity logging in argparse.
Testing
Added under
sub-packages/bionemo-llm/tests/bionemo/llm/test_lightning.pyTests for these changes can be run via: