Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial configs for perf testing on ESM2 in JET (bionemo2) #497

Open
wants to merge 46 commits into
base: main
Choose a base branch
from

Conversation

dorotat-nv
Copy link
Collaborator

@dorotat-nv dorotat-nv commented Dec 4, 2024

Adding ESM2 650M conv + perf partial configs for benchmarking with required changes

@dorotat-nv dorotat-nv changed the title add partial configs for perf testing on ESM2 in JET (bionemo2) add initial configs for perf testing on ESM2 in JET (bionemo2) Dec 4, 2024
ci/benchmarks/partial-conv/esm2_pretrain.yaml Outdated Show resolved Hide resolved
ci/benchmarks/partial-conv/esm2_pretrain.yaml Show resolved Hide resolved
@dorotat-nv dorotat-nv force-pushed the dorotat/esm2-perf-jet-bionemo2 branch from e26457a to 5d4c3ec Compare December 11, 2024 16:40
@dorotat-nv
Copy link
Collaborator Author

/build-ci

Copy link
Collaborator

@skothenhill-nv skothenhill-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please mirror the changes for ESM2 train in both Geneformer and the generic train entrypoint used by pydantic: bionemo-llm/src/bionemo/llm/train.py

@dorotat-nv
Copy link
Collaborator Author

/build-ci

@dorotat-nv
Copy link
Collaborator Author

/build-ci

@dorotat-nv
Copy link
Collaborator Author

Looks good, please mirror the changes for ESM2 train in both Geneformer and the generic train entrypoint used by pydantic: bionemo-llm/src/bionemo/llm/train.py

@skothenhill-nv , added required changes, at least the ones I am aware of

Copy link
Collaborator

@skothenhill-nv skothenhill-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating the pydantic paths! Love the new model valdiator.

@dorotat-nv dorotat-nv enabled auto-merge (squash) December 12, 2024 16:30
@dorotat-nv dorotat-nv self-assigned this Dec 12, 2024
@dorotat-nv
Copy link
Collaborator Author

/build-ci

@dorotat-nv
Copy link
Collaborator Author

/build-ci

@dorotat-nv
Copy link
Collaborator Author

/build-ci

@dorotat-nv
Copy link
Collaborator Author

/build-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants