Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bucket batch sampler to support DDP sampling #478

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

guoqing-zhou
Copy link
Collaborator

(NOTE: delete these instructional lines as you fill-out this PR template)

(NOTE: _template is designed to be filled-in and used as the squashed commit message for the entire PR. Italicized text is intended to be deleted as you fill in this template. Use the text between the ---)


High level summary of changes. Try to keep this as short and informative as possible: less is more.

Describe your changes. You can be more detailed and descriptive here. If it is a code change, Be sure to answer:

  • What is changing?
  • What is the new or fixed functionality?
  • Why or when would someone want to use these changes?
  • How can someone use these changes?

Summary

High level summary of changes. Try to keep this as short and informative as possible: less is more.

Details

Describe your changes. You can be more detailed and descriptive here.

Usage

How does a user interact with the changed code?

python -m your.new.module -and -all -options

Testing

How do you prove that your code behaves the way you claim?

Tests for these changes can be run via:

pytest -v tests/your/new/or/existing/test_functions.py::test_function

(NOTE: also delete this checklist as you fill-out this PR template)

Most of the changes to files with extensions *.py, *.yaml, *.yml, Dockerfile* or requirements.txt DO REQUIRE both pytest- and jet- CI stages.

@guoqing-zhou guoqing-zhou changed the title [Draft] refactor bucket batch sampler to support DDP sampling DRAFT: refactor bucket batch sampler to support DDP sampling Nov 26, 2024
@guoqing-zhou guoqing-zhou marked this pull request as draft November 26, 2024 01:28
@guoqing-zhou guoqing-zhou changed the title DRAFT: refactor bucket batch sampler to support DDP sampling Refactor bucket batch sampler to support DDP sampling Nov 26, 2024
@guoqing-zhou guoqing-zhou requested a review from DejunL November 26, 2024 22:28
Copy link
Collaborator

@DejunL DejunL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did my first pass. Have some minor comments. I would need to look more into the how lightning engage with the DistributedSampler to get an understanding of the underlying logics so to come up with a test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants