-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor bucket batch sampler to support DDP sampling #478
Draft
guoqing-zhou
wants to merge
10
commits into
main
Choose a base branch
from
guoqingz/bucket_batch_sampler_ddp_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoqing-zhou
changed the title
[Draft] refactor bucket batch sampler to support DDP sampling
DRAFT: refactor bucket batch sampler to support DDP sampling
Nov 26, 2024
guoqing-zhou
changed the title
DRAFT: refactor bucket batch sampler to support DDP sampling
Refactor bucket batch sampler to support DDP sampling
Nov 26, 2024
DejunL
requested changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did my first pass. Have some minor comments. I would need to look more into the how lightning engage with the DistributedSampler to get an understanding of the underlying logics so to come up with a test
sub-packages/bionemo-size-aware-batching/src/bionemo/size_aware_batching/sampler.py
Outdated
Show resolved
Hide resolved
sub-packages/bionemo-size-aware-batching/src/bionemo/size_aware_batching/sampler.py
Outdated
Show resolved
Hide resolved
sub-packages/bionemo-size-aware-batching/src/bionemo/size_aware_batching/sampler.py
Outdated
Show resolved
Hide resolved
sub-packages/bionemo-size-aware-batching/src/bionemo/size_aware_batching/sampler.py
Show resolved
Hide resolved
sub-packages/bionemo-size-aware-batching/src/bionemo/size_aware_batching/sampler.py
Show resolved
Hide resolved
sub-packages/bionemo-size-aware-batching/src/bionemo/size_aware_batching/sampler.py
Show resolved
Hide resolved
sub-packages/bionemo-size-aware-batching/src/bionemo/size_aware_batching/sampler.py
Outdated
Show resolved
Hide resolved
sub-packages/bionemo-size-aware-batching/src/bionemo/size_aware_batching/sampler.py
Show resolved
Hide resolved
sub-packages/bionemo-size-aware-batching/src/bionemo/size_aware_batching/sampler.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(NOTE: delete these instructional lines as you fill-out this PR template)
(NOTE: _template is designed to be filled-in and used as the squashed commit message for the entire PR. Italicized text is intended to be deleted as you fill in this template. Use the text between the
---
)High level summary of changes. Try to keep this as short and informative as possible: less is more.
Describe your changes. You can be more detailed and descriptive here. If it is a code change, Be sure to answer:
Summary
High level summary of changes. Try to keep this as short and informative as possible: less is more.
Details
Describe your changes. You can be more detailed and descriptive here.
Usage
How does a user interact with the changed code?
Testing
How do you prove that your code behaves the way you claim?
Tests for these changes can be run via:
(NOTE: also delete this checklist as you fill-out this PR template)
Most of the changes to files with extensions
*.py
,*.yaml
,*.yml
,Dockerfile*
orrequirements.txt
DO REQUIRE bothpytest-
andjet-
CI stages.SKIP_CI
label to your PR?PYTEST_NOT_REQUIRED
label to your PR?JET_NOT_REQUIRED
label to your PR?